Repository navigation
Cover action-pin fallbacks in no-emit and dry-run compilation - #74892
Conversation
…tion Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟡 Changes recommended
The test leaves noEmit enabled and relies on a cumulative warning count, so it does not independently verify dry-run compilation or the warning produced by each case.
2 open issues
What changed in this PR
This PR expands regression coverage for compiler-generated action-pin fallbacks in no-emit and dry-run compilation, while refreshing generated workflow lock files.
Changes:
- Extends fallback coverage across action/release modes and no-emit/dry-run scenarios.
- Verifies unresolved generated references remain warnings and no-emit compilation does not write lock files.
- Updates pinned
astral-sh/setup-uvreferences from v10.3.2 to v10.3.3.
Review findings:
- Moderate, 3 votes: The dry-run case is only exercised with
noEmit=true, so dry-run-only compilation is not covered; separate cases and conditional lock-file assertions are needed. - Moderate, 4 votes: The cumulative warning count can make the assertions pass without validating warnings from the current compilation; reset the count or assert that it increases per case.
| File | Description |
|---|---|
pkg/workflow/compiler_lint_test.go |
Adds regression coverage for generated action fallback behavior. |
.github/workflows/weekly-issue-summary.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/stale-repo-identifier.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/python-data-charts.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/prompt-clustering-analysis.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/portfolio-analyst.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/org-health-report.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/github-mcp-structural-analysis.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/detection-analysis-report.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-spending-forecast.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-security-observability.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-repo-chronicle.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-performance-summary.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-news.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-issues-report.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-experiment-report.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-code-metrics.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/daily-agentrx-trace-optimizer.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/copilot-session-insights.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/copilot-pr-nlp-analysis.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/audit-workflows.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
.github/workflows/api-consumption-report.lock.yml |
Updates the pinned setup-uv action to v10.3.3. |
Review effort: Lite (auto)
| require.NoError(t, compiler.CompileWorkflow(path), "no-emit and dry-run compilation must preserve generated references") | ||
| require.Positive(t, compiler.GetWarningCount(), "generated fallbacks must still produce warnings") |
| compiler.SetNoEmit(true) | ||
| for _, dryRun := range []bool{false, true} { | ||
| compiler.SetDryRun(dryRun) | ||
| require.NoError(t, compiler.CompileWorkflow(path), "no-emit and dry-run compilation must preserve generated references") | ||
| require.Positive(t, compiler.GetWarningCount(), "generated fallbacks must still produce warnings") | ||
| _, err := os.Stat(lockPath) | ||
| require.True(t, os.IsNotExist(err), "no-emit compilation must not write a lock file") | ||
| } |
|
🎉 This pull request is included in a new release. Release: |
v0.93.5 rejected compiler-generated action tag fallbacks with CTR-002 errors, blocking existing workflows and the documented triage example when SHA resolution failed. The production fix is already present; this change extends its regression coverage.