Skip to content

test: share schema inputs and restore fixture coverage - #3449

Merged
schani merged 12 commits into
masterfrom
enable-dart-swift-ts-tests
Sep 5, 2026
Merged

test: share schema inputs and restore fixture coverage#3449
schani merged 12 commits into
masterfrom
enable-dart-swift-ts-tests

Conversation

@schani

@schani schani commented Sep 5, 2026

Copy link
Copy Markdown
Member

Enable Swift JSON/schema CI on macOS and add TypeScript schema fixtures to the TypeScript job. Broaden Swift final/hashable, TypeScript type/const, and Dart from-map coverage while retaining the existing option cases.

The existing Swift fixture now also compiles and round-trips code generated through JSON Schema. Keep source comparisons where applicable and validate behavior when names legitimately differ; renderer naming is unchanged. Replaces the withdrawn naming change in #3438 without adding another fixture.

Centralize optional language-specific schema discovery and the Unicode length regression inputs. Dependent fixes register their inputs here; merge this PR first.

Validation: build; 490 Swift/Dart/TypeScript fixtures before the schema-roundtrip extension; 85 existing Swift fixture cases plus ten miscellaneous cases with schema roundtrips; three retained option cases; seven Unicode samples; discovery/filtering, workflow YAML, and formatting checks. Includes the reviewed Unicode fixes from #3442#3445, which were merged into this branch.

After merging current master: build and all 154 Dart JSON/schema cases pass; from-map, copy-with, and required-props option coverage is retained.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Generated-output differences

23 files differ — 0 modified, 20 new, 3 deleted
40249 changed lines — +39765 / −484

Open the generated-output report →

@schani

schani commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Why does this show 2 deleted files?

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Generated-output differences

60 files differ — 34 modified, 23 new, 3 deleted
41061 changed lines — +40529 / −532

Open the generated-output report →

@schani

schani commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Those were generated snapshots, not deleted source or input files: two Swift simple-object.json runs (final-classes and hashable), plus TypeScript pokedex.json with prefer-types. I had replaced those targeted runs with broader combination tests.

Restored all three original runs alongside the broader coverage in 52cb8e0; all three pass.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Generated-output differences

20 files differ — 0 modified, 20 new, 0 deleted
39765 changed lines — +39765 / −0

Open the generated-output report →

@schani
schani enabled auto-merge (squash) September 5, 2026 17:30
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Generated-output differences

20 files differ — 0 modified, 20 new, 0 deleted
39765 changed lines — +39765 / −0

Open the generated-output report →

* fix(dart): count Unicode code points in string bounds

* test(dart): reuse shared Unicode length fixture
* fix(zod): count Unicode code points for string length

* test(zod): use shared Unicode length cases
* fix(effect): count Unicode code points for string length

* test(effect): use shared Unicode length cases
* fix(javascript): count Unicode code points for string length

* test(javascript): use shared Unicode length cases
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Generated-output differences

1038 files differ — 1013 modified, 25 new, 0 deleted
42301 changed lines — +41265 / −1036

Open the generated-output report →

@schani
schani merged commit f00220d into master Sep 5, 2026
35 checks passed
@schani
schani deleted the enable-dart-swift-ts-tests branch September 5, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant