chore: pin swift-sdk to fork branch shipping numberValue#29
Merged
Conversation
Eats our own dog food on modelcontextprotocol/swift-sdk#226 (closes upstream issue #225). The fork branch (gsdali/swift-sdk#add-value-numbervalue) ships Value.numberValue — exactly the helper our Server.swift dispatch wanted. Package.swift: dep flips from modelcontextprotocol/swift-sdk from: "0.11.0" to gsdali/swift-sdk branch: "add-value-numbervalue" with a comment noting the pin is temporary and reverts to the upstream tag floor once swift-sdk#226 merges. Server.swift: drops the local `extension Value { var asDouble }` back-port (was added in OCCTMCP v1.3) and switches all 19 dispatch sites — translate / rotate / mirror / pattern / circular / select_topology / find_correspondences scalar + array reads — from .asDouble to .numberValue. Identical semantics; we just stop maintaining a private copy of the helper. No release tag — main is intentionally on a fork pin until upstream merges. Cohort downstream consumers building OCCTMCP from main pull the fork transparently; the moment upstream lands we revert Package.swift to `from: "0.11.0"` and tag a release. 25/25 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eats our own dog food on modelcontextprotocol/swift-sdk#226 (closes upstream #225). The fork branch (
gsdali/swift-sdk#add-value-numbervalue) shipsValue.numberValue— exactly the helper ourServer.swiftdispatch wanted.modelcontextprotocol/swift-sdk from: "0.11.0"togsdali/swift-sdk branch: "add-value-numbervalue"with a comment noting the pin is temporary and reverts to the upstream tag floor once #226 merges.extension Value { var asDouble }back-port (added in v1.3) and switches all 19 dispatch sites (translate / rotate / mirror / pattern / circular / select_topology / find_correspondences scalar + array reads) from.asDoubleto.numberValue. Identical semantics; we just stop maintaining a private copy.No release tag for this — main is intentionally on a fork pin until upstream merges. The moment upstream lands we revert
Package.swifttofrom: "0.11.0"and tag a release.Test plan
swift buildcleanswift test— 25/25swift package resolvepulls the fork branch (gsdali/swift-sdk @ add-value-numbervalue (62ac56f))🤖 Generated with Claude Code