Wrap guides-nav includes in {% if cat_data %} instead of a {% break %} guard - #3
Open
rolfedh wants to merge 1 commit into
Open
Conversation
…} guard
The pre-loop {% unless cat_data %}{% break %}{% endunless %} guard in guide-nav-sidebar.html and guide-metadata-bar.html renders the same as gating the body on cat_data, but {% break %} outside a loop has no Qute equivalent, so the Jekyll-to-Roq converter cannot translate it. Wrapping the include body in {% if cat_data %}...{% endif %} is behavior-identical in Jekyll and converts cleanly to Roq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your two new guides-nav includes (
guide-nav-sidebar.html,guide-metadata-bar.html) open with:{% unless cat_data %}{% break %}{% endunless %}{% break %}outside a loop has no equivalent in Roq's Qute templating, so Holly's Jekyll-to-Roq converter (haq-it, for quarkusio.github.io#2683) can't translate it. This wraps each include body in{% if cat_data %}...{% endif %}instead — behavior-identical in Jekyll, and it converts cleanly to Roq. Four-line change, no output difference.I also opened a converter-side PR to Holly (holly-cummins/quarkus-roq#1) so
haq-itlearns to handle the guard directly, but this source change unblocks the conversion regardless of merge order.Separately: this branch predates quarkusio.github.io#2744, so its
assets/css/main.scssstill has the old$baseurl: "{{ site.baseurl }}"line that trips the converter's SCSS guard. A rebase onto currentmainclears it.