Skip to content

Wrap guides-nav includes in {% if cat_data %} instead of a {% break %} guard #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolfedh wants to merge 1 commit into
base: navigation-experiment
Choose a base branch
from
Open

Wrap guides-nav includes in {% if cat_data %} instead of a {% break %} guard #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _includes/guide-metadata-bar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
{% assign docversion_index = docversion | replace: '.', '-' %}
{% assign cat_data = site.data.versioned[docversion_index].index.categories.categories %}

{% unless cat_data %}{% break %}{% endunless %}

{% if cat_data %}
{% assign guide_cat_labels = "" | split: "," %}
{% assign guide_cat_ids = "" | split: "," %}
{% assign guide_topics = nil %}
Expand Down Expand Up @@ -152,3 +151,4 @@
});
</script>
{% endif %}
{% endif %}
4 changes: 2 additions & 2 deletions _includes/guide-nav-sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
{% assign docversion_index = docversion | replace: '.', '-' %}
{% assign cat_data = site.data.versioned[docversion_index].index.categories.categories %}

{% unless cat_data %}{% break %}{% endunless %}

{% if cat_data %}
<nav class="guide-nav-sidebar">
{% for cat in cat_data %}
{% assign cat_has_current = false %}
Expand Down Expand Up @@ -77,3 +76,4 @@
</details>
{% endfor %}
</nav>
{% endif %}