Repository navigation
Document the alert component - #7
Merged
Merged
Conversation
Adds the Alert page with a screen recording from the iOS simulator: the confirm path updates the page, the dismiss path leaves it alone. That asymmetry is the component's one surprise, so the page states it twice — under the video and as a warning in the contract section. MP4 rather than GIF, as with Button: 95 KB against 1.7 MB for the same clip as a GIF at less than half the frame rate. The submodule points at the registry's alert-component branch, since the sources the page includes are not on the registry's main yet. It needs re-pointing at main once that lands.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
The attribution belongs with the code rather than in the page's prose: it stays in the header of AlertComponent.swift and alert_controller.js, so it travels with the file when someone copies it out. The submodule moves up to pick up the Stimulus header.
Same clip as the iOS one: dismissing leaves the page alone, confirming updates it. Worth having both, because the destructive styling is the one place the platforms visibly differ — Android has no destructive button style, so the confirm button is tinted with the theme's error colour.
The alert sources are on the registry's main now, so the pointer no longer has to sit on a branch.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Alert page, with a screen recording from the iOS simulator.
The video shows both paths on purpose: confirming reports back and the page acts on it, dismissing reports nothing and leaves it alone. That asymmetry is the component's one real surprise — a web side that registers a callback per
showleaks one on every cancelled alert — so the page states it under the video and again as a warning in the contract section.MP4 rather than GIF, same as Button: 95 KB against 1.7 MB for the same clip as a GIF at less than half the frame rate.
The submodule pointer moves to the registry's
alert-componentbranch, because the sources this page includes (registry/alert/) are not on the registry'smainyet. Merge that PR first, then re-point the submodule atmainbefore merging this one:git submodule update --remote vendor/hotwire-bridge-components git commit -am "Point the registry submodule back at main"npm run buildpasses as it stands — the includes resolve and the page renders.