Repository navigation
FIX recursive wrap, plus controlling thread cleanups and doc improvements - #294
Merged
Merged
Conversation
itamarst
changed the title
itamarst
changed the title
itamarst
marked this pull request as ready for review
November 3, 2026 16:37
ogrisel
reviewed
Nov 4, 2026
ogrisel
left a comment
ogrisel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fixes. Overall LGTM besides the following minor suggestions.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…nto 292-controlling-thread-part-2
Contributor
Author
|
I've addressed the review comments |
ogrisel
reviewed
Nov 4, 2026
Contributor
Author
|
I'll take a look at the failing tests. |
…nto 292-controlling-thread-part-2
Contributor
|
It seems that the flexiblas CI broken, probably for reasons unrelated to this PR but let's double check. |
ogrisel
approved these changes
Nov 5, 2026
ogrisel
left a comment
ogrisel
left a comment
Contributor
There was a problem hiding this comment.
Thanks very much for the follow-up. I push a commit to cleanup CRLF chars in the readme (seems to have been caused by github bug...).
I had another look at the diff and I think this is good to go. Let's merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Fixes #293