Update protobuf-java to 4.35.0#2381
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf-java dependency from version 3.25.9 to 4.35.0. Feedback was provided regarding the need to also update the protobuf-java-util dependency to the same version to maintain parity and avoid potential binary incompatibilities or runtime errors caused by mixing major versions of Protocol Buffers artifacts.
| lazy val paiges = Def.setting("org.typelevel" %%% "paiges-core" % "0.4.4") | ||
| lazy val protobufJava = | ||
| Def.setting("com.google.protobuf" % "protobuf-java" % "3.25.9") | ||
| Def.setting("com.google.protobuf" % "protobuf-java" % "4.35.0") |
There was a problem hiding this comment.
The protobuf-java-util dependency on line 32 should also be updated to 4.35.0 to maintain version parity with protobuf-java. Mixing different major versions (3.x and 4.x) of Protocol Buffers artifacts in the same project is highly discouraged as it can lead to binary incompatibilities and runtime errors such as NoSuchMethodError due to breaking changes in the internal runtime APIs.
References
- When updating library versions, ensure that all related libraries are updated to the same version to prevent potential binary compatibility issues or runtime errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
- Coverage 85.18% 85.13% -0.05%
==========================================
Files 196 196
Lines 49379 49379
Branches 12196 12196
==========================================
- Hits 42062 42038 -24
- Misses 7317 7341 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.9to4.35.0⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (3.25.9).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: