Fix missing :p256dh atom#2
Closed
speeddragon wants to merge 2 commits into
Closed
Conversation
Owner
|
Oh my, this exhibits some interesting behavior. Since the atom does occur in a type spec, if the compiler is invoked, then the atom exists in the VM. I think it will be best to avoid usage of |
Merged
Owner
|
closing in favor of #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.to_existing_atom(key)will give an error because:p256dhatom doesn't exist. I think in your application, you have this atom, so it works when you use this dependency.I believe that
:authis common, but to not depend on other dependencies, I've added it as well.Feel free to modify to improve this version, not sure which alternative we can have to have an atom here that is useful for this to use and
to_existing_atomto not give an error.