Skip to content

Fix missing :p256dh atom #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
speeddragon wants to merge 2 commits into from
Closed

Fix missing :p256dh atom #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dbfe95
Fix missing :p256dh atom
speeddragon Jul 3, 2025
ec51274
Fix test
speeddragon Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/web_push/subscription.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,15 @@ defmodule WebPushEx.Subscription do
key = String.to_existing_atom(key)

value =
if key == :endpoint and is_binary(value) do
URI.parse(value)
else
value
cond do
key == :endpoint and is_binary(value) ->
URI.parse(value)

key in [:p256dh, :auth, :keys] ->
value

true ->
value
end

[{key, value} | acc]
Expand Down