Skip to content

test(engine-manager): make managed-image reclaim test explicit on macOS - #1

Draft
kvnloo wants to merge 1 commit into
developfrom
fix/17-darwin-uninstall-test-guard
Draft

kvnloo wants to merge 1 commit into
developfrom
fix/17-darwin-uninstall-test-guard

Conversation

@kvnloo

@kvnloo kvnloo commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Description

Downstream first slice for NVIDIA#17.

procImage intentionally returns an empty executable path on macOS because the current implementation relies on Linux /proc. The production stop path therefore declines reclamation when ownership cannot be verified.

TestUninstallTerminatesRunningInstance currently asserts successful managed-image reclamation on every platform, which makes the services test baseline fail on Darwin even though the production decline is documented behavior.

This patch skips only that Linux reclaim contract on Darwin. It does not weaken the ownership check and does not introduce a new executable-resolution primitive.

Release intent

Changelog title

n/a

Changelog body

n/a

Bumps

  • services: none
  • nvpair-cluster-manager: none
  • nvpair-engine-manager: none
  • nvpair-errors: none
  • nvpair-job-scheduler: none
  • nvpair-manual-nodes: none
  • nvpair-node-info: none
  • nvpair-node-scanner: none
  • nvpair-node-settings: none
  • nvpair-proxy: none
  • nvpair-tui: none
  • nvpair-ui-broker: none
  • nvpair-workload-manager: none

Scope

In scope:

  • make the reclaim regression explicit about its Linux-only executable-resolution contract.

Out of scope:

  • changing production reclaim behavior on macOS;
  • adding a new executable-resolution primitive.

Validation

Fork CI:

  • Build: passed
  • CI: passed
  • Release-intent validation: fixing the missing required intent block in this PR description

Risk

Test-only change. Production behavior is unchanged.

All commits are DCO-signed and the branch is based on upstream develop @ 937cf6c.

Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant