Repository navigation
Conversation
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Downstream first slice for NVIDIA#17.
procImageintentionally returns an empty executable path on macOS because the current implementation relies on Linux/proc. The production stop path therefore declines reclamation when ownership cannot be verified.TestUninstallTerminatesRunningInstancecurrently asserts successful managed-image reclamation on every platform, which makes the services test baseline fail on Darwin even though the production decline is documented behavior.This patch skips only that Linux reclaim contract on Darwin. It does not weaken the ownership check and does not introduce a new executable-resolution primitive.
Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
In scope:
Out of scope:
Validation
Fork CI:
Risk
Test-only change. Production behavior is unchanged.
All commits are DCO-signed and the branch is based on upstream
develop@937cf6c.