Skip to content

test(engine-manager): make managed-image reclaim test explicit on macOS #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kvnloo wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

test(engine-manager): make managed-image reclaim test explicit on macOS #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions services/nvpair-engine-manager/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,10 @@ func TestPreviouslyAdoptedForeignReplacementFailsClosed(t *testing.T) {
// engine started without an executor process handle. Uninstall must reconcile
// and reclaim that exact managed image before deleting it.
func TestUninstallTerminatesRunningInstance(t *testing.T) {
if runtime.GOOS == "darwin" {
t.Skip("managed-image reclamation intentionally declines when procImage cannot verify the executable")
}

baseDir := t.TempDir()
bin := filepath.Join(baseDir, "fake", "fakeu"+strconv.Itoa(os.Getpid())+exeExt())
if err := os.MkdirAll(filepath.Dir(bin), 0o755); err != nil {
Expand Down
Loading