ORC: omit initial-defaults only for complete embedded field IDs - #275
Merged
cbb330 merged 1 commit intoAug 27, 2026
Merged
Conversation
Twin of linkedin#268 for openhouse-1.5.2. Name-mapped or partially annotated files cannot prove a column was never written, so they keep the null-synthesizing path instead of filling a default.
mkuchenbecker
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openhouse-1.5.2.chbush/oh152-orc-defaults-267(273's old branch) instead ofopenhouse-1.5.2, so this follow-up lands the omit-complete-embedded-IDs change on the 1.5.2 line (git patch-idmatches ORC: omit initial-defaults only for complete embedded field IDs #274).#276 (exact copy of #269) is stacked on this PR. Both target
openhouse-1.5.2— merge this first.Testing Done
openhouse-1.5.2(tip is [default values] ORC/Spark: forward-port default-value reads via idToConstant (LI #76) #273) applied cleanlyDependencies
openhouse-1.5.2. This PR is the missing ORC: omit initial-defaults only for complete embedded field IDs #274.