Skip to content

[default values] ORC: don't push file filters for omitted initial-default fields - #276

Merged
cbb330 merged 1 commit into
openhouse-1.5.2from
chbush/oh152-orc-defaults-269
Aug 28, 2026
Merged

[default values] ORC: don't push file filters for omitted initial-default fields#276
cbb330 merged 1 commit into
openhouse-1.5.2from
chbush/oh152-orc-defaults-269

Conversation

@cbb330

@cbb330 cbb330 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Exact copy of #269 onto openhouse-1.5.2.
  • Same omit-from-SARG rule, same TypeUtil NestedField.from default preservation, same Spark scan/reader tests.

Required 1.5.2-only delta: ExpressionToSearchArgument.predicate already skipped non-BoundReference terms on this line; kept that conjunct and added the omitted-field-id check. API/ORC tests in this tree are JUnit 5/AssertJ (JUnit 4 Assert is not on those classpaths). Spark tests stay JUnit 4, copied into spark/v3.5.

Stacked on #275 (the #274 retarget / exact copy of #268). Both PRs target openhouse-1.5.2. Merge 275 first; this PR then shows only the #269 commit.

Testing Done

export JAVA_HOME=$(/usr/libexec/java_home -v 17)
./gradlew -DsparkVersions=3.5 -DscalaVersion=2.12 -DhiveVersions= -DflinkVersions= \
  :iceberg-api:test --tests 'org.apache.iceberg.types.TestTypeUtil.testAssignFreshIdsPreservesDefaults' \
  :iceberg-orc:test --tests 'org.apache.iceberg.orc.TestExpressionToSearchArgument.testDisables*' \
  --tests 'org.apache.iceberg.orc.TestExpressionToSearchArgument.testMixedPhysicalAndOmittedDefaultPredicates' \
  :iceberg-spark:iceberg-spark-3.5_2.12:test \
  --tests 'org.apache.iceberg.spark.source.TestSparkOrcInitialDefaultScan' \
  --tests 'org.apache.iceberg.spark.data.TestSparkOrcReaderForFieldsWithDefaultValue' \
  -x generateGitProperties

@cbb330
cbb330 changed the base branch from chbush/oh152-orc-defaults-268-onto-152 to openhouse-1.5.2 August 27, 2026 02:12
@cbb330
cbb330 force-pushed the chbush/oh152-orc-defaults-269 branch from 82a856d to c207744 Compare August 27, 2026 03:14
@cbb330
cbb330 merged commit 39df55d into openhouse-1.5.2 Aug 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants