[default values] ORC: don't push file filters for omitted initial-default fields - #276
Merged
Merged
Conversation
cbb330
changed the base branch from
chbush/oh152-orc-defaults-268-onto-152
to
openhouse-1.5.2
August 27, 2026 02:12
2 tasks
cbb330
force-pushed
the
chbush/oh152-orc-defaults-269
branch
from
August 27, 2026 03:14
82a856d to
c207744
Compare
mkuchenbecker
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openhouse-1.5.2.NestedField.fromdefault preservation, same Spark scan/reader tests.Required 1.5.2-only delta:
ExpressionToSearchArgument.predicatealready skipped non-BoundReferenceterms on this line; kept that conjunct and added the omitted-field-id check. API/ORC tests in this tree are JUnit 5/AssertJ (JUnit 4Assertis not on those classpaths). Spark tests stay JUnit 4, copied intospark/v3.5.Stacked on #275 (the #274 retarget / exact copy of #268). Both PRs target
openhouse-1.5.2. Merge 275 first; this PR then shows only the #269 commit.Testing Done