fix: make sure export directory is writable#9941
Open
skaphi wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
dmadisetti
reviewed
Jun 21, 2026
| ignore=(shutil.ignore_patterns("index.html")), | ||
| ) | ||
| # Ensure output is writable (source may be read-only, e.g. nix store) | ||
| for root, _dirs, files in os.walk(dirpath): |
Member
There was a problem hiding this comment.
Should we not just bail if RO? This attempts to modify the permissions- which I don't think will solve your Nix issue
Contributor
Author
There was a problem hiding this comment.
It does solve the issue I reported. It only modifies permissions of copied files, not in nix store. I dont love this solution either but could not think of much cleaner solution. Ideally python should have a function like shutil.copytree but ignored copied from permissions and always makes destination files writable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #9940
On NixOS packages are stored in read only directory
/nix/storeand during wasm export marimo copies files from there but keeps the read only permissions. This fixes so that copied files explicitly get the right permissions.📋 Pre-Review Checklist
✅ Merge Checklist