Skip to content

fix: make sure export directory is writable #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skaphi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make sure export directory is writable #9941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions marimo/_server/export/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,7 @@ def export_assets(self, directory: Path) -> None:
if not dirpath.exists():
dirpath.mkdir(parents=True, exist_ok=True)

import os
import shutil

shutil.copytree(
Expand All @@ -743,6 +744,12 @@ def export_assets(self, directory: Path) -> None:
dirs_exist_ok=True,
ignore=(shutil.ignore_patterns("index.html")),
)
# Ensure output is writable (source may be read-only, e.g. nix store)
for root, _dirs, files in os.walk(dirpath):

@dmadisetti dmadisetti Jun 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not just bail if RO? This attempts to modify the permissions- which I don't think will solve your Nix issue

@skaphi skaphi Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does solve the issue I reported. It only modifies permissions of copied files, not in nix store. I dont love this solution either but could not think of much cleaner solution. Ideally python should have a function like shutil.copytree but ignored copied from permissions and always makes destination files writable.

@skaphi skaphi Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9940

os.chmod(root, os.stat(root).st_mode | 0o755)
for f in files:
fp = os.path.join(root, f)
os.chmod(fp, os.stat(fp).st_mode | 0o644)

def export_public_folder(
self, directory: Path, marimo_file: MarimoPath
Expand Down
Loading