Skip to content

smite-ir: implement BuildChannelUpdate operation#110

Open
devvaansh wants to merge 1 commit into
morehouse:masterfrom
devvaansh:build-channel-update
Open

smite-ir: implement BuildChannelUpdate operation#110
devvaansh wants to merge 1 commit into
morehouse:masterfrom
devvaansh:build-channel-update

Conversation

@devvaansh

@devvaansh devvaansh commented May 31, 2026

Copy link
Copy Markdown
Contributor

Enables programs that build signed channel_update messages and send
them to the target. The signature is computed internally over the double-SHA256 of the message body, using the supplied node secret key (per BOLT 7). All other wire fields are passed as variable inputs so they can be reused
and mutated by the existing IR machinery.

Ref: #71

@devvaansh devvaansh marked this pull request as draft May 31, 2026 21:31
@devvaansh devvaansh force-pushed the build-channel-update branch 4 times, most recently from 620242e to e7fb274 Compare June 1, 2026 04:28
@devvaansh devvaansh changed the title smite-ir: implement BuildChannelUpdate operation smite-ir: implement BuildChannelUpdate operation Jun 1, 2026
@devvaansh devvaansh force-pushed the build-channel-update branch from e7fb274 to 4b04a9d Compare June 3, 2026 21:38
@devvaansh devvaansh marked this pull request as ready for review June 3, 2026 21:43
@devvaansh

Copy link
Copy Markdown
Contributor Author

Fee fields now use ForwardingFee type (post-#99).

@ekzyis ekzyis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ShortChannelId changes look unrelated. Should they be in 4b04a9d, or in a different commit?

@devvaansh devvaansh force-pushed the build-channel-update branch 2 times, most recently from 326a60a to dbf94ea Compare June 7, 2026 02:04
@devvaansh

devvaansh commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

The ShortChannelId changes look unrelated. Should they be in 4b04a9d, or in a different commit?

I initially bundled those SCID changes because I was refactoring nearby code while working on BuildChannelUpdate, and it felt like a natural cleanup,I've dropped them from this commit. If we still want to simplify tweak_short_channel_id → tweak_u64, I'll open it as a separate PR so it can be reviewed on its own merits. Force-pushed to 326a60a.

@morehouse morehouse left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

Comment thread smite-ir/src/tests.rs
Comment thread smite-scenarios/src/executor.rs Outdated
Comment thread smite-scenarios/src/executor.rs Outdated
@devvaansh devvaansh force-pushed the build-channel-update branch from dbf94ea to 77f3d63 Compare June 9, 2026 06:57
Comment thread smite-ir/src/operation.rs Outdated
@devvaansh devvaansh force-pushed the build-channel-update branch from 77f3d63 to b9204de Compare June 10, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants