Chore: remove convert to fanci#209
Merged
Merged
Conversation
Closed
rugwed-lokhande
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the obsolete
convert_to_fanciwavefunction utility. This function previously set up the classGeneratedFanCI, which is equivalent to theProjectedSchrodingerPyCIandProjectedSchrodingerFanCIclasses. All of these three classes inherit from a version of the Fanci class that lives in PyCI now. They set up the compute overlap and compute overlap deriv methods, and have their own optimize methods too.In order to reduce the maintenance burden, the
GeneratedFanCIclass, which lives insideconvert_to_fancihas been removed.convert_to_fanciinitialized theGeneratedFanCIclass with the input parameters the user passes to the function. Since it only passes the parameters and does not do any data transformation or manipulation,convert_to_fancihas also been removed from the code base.Test updates:
convert_to_fancineeds to be updated to the new interface. The import forconvert_to_fancihas been removed. Since the tests are skipped, it is not an issue that we do not import it.Examples:
convert_to_fanci