Repository navigation
Make GridFS waveform replacement failure-safe - #955
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
+ Coverage 72.06% 72.09% +0.02%
==========================================
Files 182 182
Lines 35966 36014 +48
Branches 2532 2532
==========================================
+ Hits 25918 25963 +45
- Misses 9142 9145 +3
Partials 906 906 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:01
Member
Author
|
Draft decision required (renewed review) Atomic and ensemble GridFS overwrite paths are repaired, but distributed bulk overwrite still lacks compare-and-set semantics for an existing waveform reference. Keep this PR draft until the distributed overwrite contract is designed and tested. |
wangyinz
force-pushed
the
codex/issue-814-gridfs-overwrite
branch
from
August 22, 2026 20:59
f007386 to
1e4e680
Compare
wangyinz
marked this pull request as ready for review
August 22, 2026 20:59
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #814.
Summary
update_dataandsave_data(overwrite=True)references with compare-and-set.write_distributed_data(overwrite=True)before scheduler or storage execution because distributed bulk insert cannot safely replace an existing waveform reference.Failure contract
A failed stage or waveform-reference update preserves the previous readable GridFS object. Cleanup targets only the newly staged object. Failure to delete an old object after commit is reported without reverting the committed new reference.
Verification