prevent ship's ghost images#118
Merged
Merged
Conversation
…ocks If you jump the ship a further than 3 mapblocks, you see a ghost image of your ship due to the cache of the client. Once you get withing activation range of the ghost image, it disappears. To prevent this we force the mapblock of the source location to the players affected
Contributor
|
Did you test this with ships split across multiple mapblocks? Also might be worth checking the distance traveled to avoid unnecessary sending. |
Contributor
Author
|
I did not test it with ships spanning multiple map blocks, nor did I bother checking the distance since this would add more complexity to a an otherwise super simple fix. that does not cause very much more data to be sent to the client. |
Member
|
looks sane, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you jump the ship a further than 3 mapblocks, you see a ghost image of your ship due to the cache of the client. Once you get withing activation range of the ghost image, it disappears. To prevent this we force the mapblock of the source location to the players affected