enhancement:- Added Queue Support for Zendesk#1321
Conversation
|
Warning Review limit reached
More reviews will be available in 36 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR extends Zendesk ticket integration to route ticket creation requests to context-specific group IDs. It introduces a ChangesContext-Aware Zendesk Ticket Routing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/mobility-core/src/Kernel/External/Ticket/Interface/Types.hs`:
- Around line 71-72: CreateTicketReq currently declares ticketContext ::
TicketContext (non-optional) and derives FromJSON, causing decoding failures for
payloads that omit ticketContext; update the JSON decoding to be
backward-compatible by either (A) changing the field to ticketContext :: Maybe
TicketContext and adjust downstream usages to handle Nothing, or (B) implement a
custom FromJSON instance for CreateTicketReq that treats a missing
"ticketContext" as a sensible default (e.g., IssueTicket) when parsing; modify
the FromJSON for CreateTicketReq (referencing CreateTicketReq, ticketContext,
TicketContext, and IssueTicket) so existing producers' payloads without the
field still decode correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fb1de9e9-113a-47fa-a85f-b8a8d7b823b7
📒 Files selected for processing (3)
lib/mobility-core/src/Kernel/External/Ticket/Interface/Types.hslib/mobility-core/src/Kernel/External/Ticket/Interface/Zendesk.hslib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs
ea0d396 to
d638763
Compare
d638763 to
1521cbc
Compare
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
./dev/format-all-files.shSummary by CodeRabbit
New Features