Security: Potential denial of service from unbounded image decoding#5266
Open
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Open
Security: Potential denial of service from unbounded image decoding#5266tomaioo wants to merge 1 commit intonextcloud:mainfrom
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Conversation
`resizeImage()` loads arbitrary image bytes into memory and decodes them without checking input size or dimensions first. If attacker-controlled or remote-fetched image data is very large or crafted, this may cause excessive memory/CPU consumption and degrade service availability. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential denial of service from unbounded image decoding
Problem
Severity:
Medium| File:lib/Service/ImageResizer.php:L22resizeImage()loads arbitrary image bytes into memory and decodes them without checking input size or dimensions first. If attacker-controlled or remote-fetched image data is very large or crafted, this may cause excessive memory/CPU consumption and degrade service availability.Solution
Validate input size before decoding (e.g., maximum bytes), enforce pixel/dimension limits, and fail fast on oversized payloads. Prefer safe decoding paths with resource limits and consider rejecting unsupported/complex image formats.
Changes
lib/Service/ImageResizer.php(modified)