Skip to content

Security: Potential denial of service from unbounded image decoding #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Security: Potential denial of service from unbounded image decoding #5266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/Service/ImageResizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,28 @@
class ImageResizer {
public const RESIZE_MAX_X = 256;
public const RESIZE_MAX_Y = 256;
public const MAX_INPUT_BYTES = 5 * 1024 * 1024;
public const MAX_INPUT_PIXELS = 4096 * 4096;

/**
* @param string $socialData
* @return null|string
*/
public function resizeImage(string $socialData) {
$image = new Image();
if ($socialData === '' || strlen($socialData) > self::MAX_INPUT_BYTES) {
return null;
}

$size = @getimagesizefromstring($socialData);
if ($size === false || !isset($size[0], $size[1])) {
return null;
}

if ($size[0] <= 0 || $size[1] <= 0 || ($size[0] * $size[1]) > self::MAX_INPUT_PIXELS) {
return null;
}

$image = new Image();
$image->loadFromData($socialData);

if ($image->valid()) {
Expand Down