Skip to content

[NOT-787] Default session replacement prompt to no - #65

Merged
leo-notte merged 1 commit into
mainfrom
fix/session-start-safe-default
Aug 10, 2026
Merged

[NOT-787] Default session replacement prompt to no#65
leo-notte merged 1 commit into
mainfrom
fix/session-start-safe-default

Conversation

@leo-notte

@leo-notte leo-notte commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • default the existing-session replacement prompt to no
  • preserve the existing session on Enter, invalid input, or non-interactive EOF
  • continue allowing explicit y/yes and --yes to stop the existing session
  • cover safe defaults and EOF behavior in tests

Testing

  • go test ./internal/cmd -count=1

Linear: NOT-787 https://linear.app/nottelabsinc/issue/NOT-787/notte-cli-pr-65-default-session-replacement-prompt-to-no

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes replacement of an active session opt-in, preserving the existing session when the prompt receives Enter, invalid input, or EOF.

  • Changes the prompt default from [Y/n] to [y/N].
  • Accepts only explicit y or yes responses.
  • Adds unit-test coverage for the new default, invalid input, and non-interactive EOF.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The implementation consistently changes the displayed default and response parsing, while tests cover the newly specified safe-default and EOF behavior.

Important Files Changed

Filename Overview
internal/cmd/confirm.go Safely changes active-session replacement confirmation to require explicit affirmative input while preserving the --yes bypass.
internal/cmd/confirm_test.go Updates prompt expectations and covers affirmative, negative, empty, invalid, and EOF inputs.

Reviews (1): Last reviewed commit: "Default session replacement prompt to no" | Re-trigger Greptile

@leo-notte
leo-notte merged commit 4855e60 into main Aug 10, 2026
4 checks passed
@giordano-lucas giordano-lucas changed the title Default session replacement prompt to no [NOT-787] Default session replacement prompt to no Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant