Skip to content

[NOT-787] Default session replacement prompt to no #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leo-notte merged 1 commit into from
Aug 10, 2026
+8 −6
Merged

[NOT-787] Default session replacement prompt to no #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/cmd/confirm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func ConfirmActionWithIO(in io.Reader, out io.Writer, resource, id string) (bool
}

// confirmReplaceSession prompts the user to confirm stopping an existing session before starting a new one.
// Defaults to "yes" if user just presses Enter.
// Defaults to "no" if user just presses Enter or stdin reaches EOF.
func confirmReplaceSession(id string) (bool, error) {
if skipConfirmation {
return true, nil
Expand All @@ -48,7 +48,7 @@ func confirmReplaceSession(id string) (bool, error) {

// confirmReplaceSessionWithIO is the testable version of confirmReplaceSession.
func confirmReplaceSessionWithIO(in io.Reader, out io.Writer, id string) (bool, error) {
if _, err := fmt.Fprintf(out, "Session %s is currently active. A new session will be created either way.\nStop the existing session before starting the new one? [Y/n]: ", id); err != nil {
if _, err := fmt.Fprintf(out, "Session %s is currently active. A new session will be created either way.\nStop the existing session before starting the new one? [y/N]: ", id); err != nil {
return false, fmt.Errorf("failed to write prompt: %w", err)
}

Expand All @@ -59,7 +59,7 @@ func confirmReplaceSessionWithIO(in io.Reader, out io.Writer, id string) (bool,
}

response = strings.TrimSpace(strings.ToLower(response))
return response != "n" && response != "no", nil
return response == "y" || response == "yes", nil
}

// SetSkipConfirmation sets whether to skip confirmation prompts (for --yes flag).
Expand Down
8 changes: 5 additions & 3 deletions internal/cmd/confirm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,13 @@ func TestConfirmReplaceSessionWithIO_YesNo(t *testing.T) {
{"y\n", true},
{"yes\n", true},
{"Y\n", true},
{"\n", true}, // default is yes
{"\n", false}, // default is no
{"", false}, // non-interactive EOF is also no
{"n\n", false},
{"no\n", false},
{"N\n", false},
{"NO\n", false},
{"maybe\n", false},
}

for _, tt := range tests {
Expand All @@ -107,8 +109,8 @@ func TestConfirmReplaceSessionWithIO_YesNo(t *testing.T) {
if !strings.Contains(out.String(), "sess_abc") {
t.Errorf("expected prompt to contain session ID, got %q", out.String())
}
if !strings.Contains(out.String(), "[Y/n]") {
t.Errorf("expected prompt to contain [Y/n], got %q", out.String())
if !strings.Contains(out.String(), "[y/N]") {
t.Errorf("expected prompt to contain [y/N], got %q", out.String())
}
}

Expand Down
Loading