Include C++17 type_traits and C++20 chrono calendars#1
Open
trxcllnt wants to merge 5 commits intoogiroux:masterfrom
Open
Include C++17 type_traits and C++20 chrono calendars#1trxcllnt wants to merge 5 commits intoogiroux:masterfrom
trxcllnt wants to merge 5 commits intoogiroux:masterfrom
Conversation
This was referenced Oct 23, 2019
|
First, we created an abstraction for hooking in our own clock backend, the external clock API. But Paul found that didn't work when he needed the C++20 chrono stuff, which internally depends on the clock implementation. So he moved the clocks into the upstream libc++ headers, which defeats the purpose of the external clock API. I think we should take a step back and think about how to fix the external clock API/make it work for what Paul's doing, not just put our implementation into the upstream libc++ headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR and its sister PR in
ogiroux/freestandingencapsulate the changes necessary to use the C++17 type_traits and C++20 chrono calendars in cudf with the -std=c++14 flag. See the notes in that PR for a description of these commits.