Repository navigation
Clarify Dutch setup limits and wait for complete device saves - #2970
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
1 task done
olemarkus
added this pull request to stack #2972
October 24, 2026 10:26
1 of 2 tasks
olemarkus
force-pushed
the
feat/nl-onboarding-limits
branch
from
October 25, 2026 10:03
ac15ba7 to
c14e11c
Compare
1 of 2 tasks
olemarkus
force-pushed
the
feat/nl-onboarding-limits
branch
2 times, most recently
from
October 25, 2026 11:19
37204b4 to
de54b2a
Compare
olemarkus
force-pushed
the
feat/nl-onboarding-limits
branch
from
October 25, 2026 11:23
de54b2a to
ee82264
Compare
olemarkus
force-pushed
the
feat/nl-onboarding-limits
branch
from
October 25, 2026 13:38
ee82264 to
554c6e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Dutch owners who enable their first device currently get a measured-peak question even though household grid charges depend on connection size. The setup step now explains that distinction and points to turning off Capacity limit while retaining price and solar features. The running default remains visible until the owner chooses; saved limits and market-neutral guidance stay intact.
Guided setup also waits for the complete device-setting operation, including fresh reads, queued edits and local commits. Closing device details during a slow save can no longer bypass that operation through Start managing; read failures block activation too.
Depends on #2969, which supplies the guided setup and solar discovery before export. Native daily Smart-task schedules are a separate follow-up.
Tariff basis: ACM household network charges.
Validation
The fixture and prop-contract repairs for #2969's own tests now live in #2969, so each layer passes by itself.
77 focused setup/save/limits unit tests and 13 onboarding/browser regression scenarios passed, including 320/390/480 px layouts. Commit lint and UI typechecks passed. SHS2 live-backend checks covered Dutch copy, solar discovery with no observed export, disabling Capacity limit, explicit review/activation, and 320 px rendering.
SHS2 browser checks used the built settings UI through a local SDK bridge connected to the deployed backend; the saved My Homey session could not access SHS2. Homey shell/socket behavior was not exercised by that smoke test. Main was reinstalled, original settings/geography verified, and the temporary Flow price row removed.
The full-stack pre-push gate passed: static checks, 824 related runtime tests, timezone checks, and all 2,695 settings UI unit tests.
Review budget