Skip to content

Clarify Dutch setup limits and wait for complete device saves - #2970

Merged
olemarkus merged 1 commit into
feat/short-onboardingfrom
feat/nl-onboarding-limits
Oct 25, 2026
Merged

olemarkus merged 1 commit into
feat/short-onboardingfrom
feat/nl-onboarding-limits

Conversation

@olemarkus

@olemarkus olemarkus commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

What changed

Dutch owners who enable their first device currently get a measured-peak question even though household grid charges depend on connection size. The setup step now explains that distinction and points to turning off Capacity limit while retaining price and solar features. The running default remains visible until the owner chooses; saved limits and market-neutral guidance stay intact.

Guided setup also waits for the complete device-setting operation, including fresh reads, queued edits and local commits. Closing device details during a slow save can no longer bypass that operation through Start managing; read failures block activation too.

Depends on #2969, which supplies the guided setup and solar discovery before export. Native daily Smart-task schedules are a separate follow-up.

Tariff basis: ACM household network charges.

Validation

The fixture and prop-contract repairs for #2969's own tests now live in #2969, so each layer passes by itself.

77 focused setup/save/limits unit tests and 13 onboarding/browser regression scenarios passed, including 320/390/480 px layouts. Commit lint and UI typechecks passed. SHS2 live-backend checks covered Dutch copy, solar discovery with no observed export, disabling Capacity limit, explicit review/activation, and 320 px rendering.

SHS2 browser checks used the built settings UI through a local SDK bridge connected to the deployed backend; the saved My Homey session could not access SHS2. Homey shell/socket behavior was not exercised by that smoke test. Main was reinstalled, original settings/geography verified, and the temporary Flow price row removed.

The full-stack pre-push gate passed: static checks, 824 related runtime tests, timezone checks, and all 2,695 settings UI unit tests.

Review budget

  • Within 25 source files and 1,000 changed source lines, excluding tests and documentation.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olemarkus
olemarkus added this pull request to stack #2972 October 24, 2026 10:26
@olemarkus
olemarkus force-pushed the feat/nl-onboarding-limits branch from ac15ba7 to c14e11c Compare October 25, 2026 10:03
Copilot AI balanced review requested due to automatic review settings October 25, 2026 10:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@olemarkus
olemarkus force-pushed the feat/nl-onboarding-limits branch from ee82264 to 554c6e1 Compare October 25, 2026 13:38
@olemarkus
olemarkus merged commit 267995c into main Oct 25, 2026
16 of 28 checks passed
@olemarkus
olemarkus deleted the feat/nl-onboarding-limits branch October 25, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants