feat: seamless domain mode - #314
Open
vincentvdwal wants to merge 32 commits into
Open
Conversation
Deploying maps with
|
| Latest commit: |
df9587e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81eeaf5f.maps-5aj.pages.dev |
| Branch Preview URL: | https://seamless-domain-mode.maps-5aj.pages.dev |
There was a problem hiding this comment.
Pull request overview
Adds support for “seamless” (multi-layer) domains by resolving an appropriate concrete backing domain for map initialization/metadata and by introducing an optional overlay to visualize sub-domain borders.
Changes:
- Resolve backing (concrete) domains for seamless-domain map init and URL/metadata logic.
- Add a “Seamless Borders” preference + settings UI and draw border/label overlays on the map.
- Update popup value lookup and various typing/import adjustments to accommodate seamless domains.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/+page.svelte | Initializes map center/zoom using a resolved backing domain when a seamless domain is selected. |
| src/lib/url.ts | Adjusts next-URL computation to accept seamless domains and resolve a concrete domain for interval logic. |
| src/lib/stores/preferences.ts | Adds showSeamlessBorders to preferences shape. |
| src/lib/stores/om-protocol-settings.ts | Refactors imports; continues using getNextOmUrls in postReadCallback. |
| src/lib/prefetch.ts | Adjusts domain typing but currently still assumes a concrete domain grid for range computation. |
| src/lib/popup.ts | Adds seamless-aware popup value lookup and resolves concrete domain for bounds checks. |
| src/lib/metadata.ts | Fetches metadata using backing domain value for seamless domains. |
| src/lib/layers.ts | Implements seamless border overlay source/layers and updates them on URL/layer refresh. |
| src/lib/constants.ts | Adds default preference showSeamlessBorders. |
| src/lib/components/time/time-selector.svelte | Adds non-null assertions for interval fields (needs proper seamless-domain handling). |
| src/lib/components/settings/settings.svelte | Adds the Seamless Borders settings section to the settings panel. |
| src/lib/components/settings/seamless-border-settings.svelte | New toggle UI to show/hide seamless sub-domain borders. |
| src/lib/components/selection/variable-selection.svelte | Class string formatting adjustments. |
| src/lib/clipping.ts | Tightens typing for coordinate collection and removes any usage in geometry handling. |
| package.json | Bumps @openmeteo/weather-map-layer to a newer GitHub commit. |
| package-lock.json | Lockfile update for the bumped @openmeteo/weather-map-layer commit/integrity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terraputix
reviewed
Jun 10, 2026
terraputix
reviewed
Jun 23, 2026
# Conflicts: # package-lock.json # package.json # src/lib/metadata.ts # src/routes/+page.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary