-
-
Notifications
You must be signed in to change notification settings - Fork 211
[ENH] Improve NotImplementedError Messages
#1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] Improve NotImplementedError Messages
#1574
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
- Coverage 53.02% 52.72% -0.31%
==========================================
Files 36 36
Lines 4326 4326
==========================================
- Hits 2294 2281 -13
- Misses 2032 2045 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure is directly related to the code that was changed, so it may be newly introduced. Kindly check.
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the error messages are descriptive enough.
Can you also update the error messages in study.py: "Tags for studies is not (yet) supported."
…eem/openml-python into enhance-NotImplementedError
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CC: @fkiraly @SimonBlanke for review/merge.
Metadata
NotImplementedErrorMessages #1537