Skip to content

refactor(oxfmt): use Rust formatters for jsdoc code fence#23322

Open
leaysgur wants to merge 1 commit into
06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_cssfrom
06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence
Open

refactor(oxfmt): use Rust formatters for jsdoc code fence#23322
leaysgur wants to merge 1 commit into
06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_cssfrom
06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member

In addition to basic embedded (e.g. css-in-js), JSDoc also contain code fence as markdown.

This PR makes JSDoc code fence also formatted by oxc_formatter_xxx.

leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 12, 2026
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 834f364 to d1d9281 Compare June 12, 2026 07:42
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from 37f0c92 to b96be29 Compare June 12, 2026 07:44
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from d1d9281 to 19c595b Compare June 12, 2026 07:44
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from b96be29 to d176554 Compare June 12, 2026 07:47
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch 2 times, most recently from 49116ab to 72fb010 Compare June 12, 2026 07:58
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch 2 times, most recently from 3020e7c to eb01d7a Compare June 12, 2026 08:25
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 72fb010 to 45b346e Compare June 12, 2026 08:25
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from eb01d7a to c30cd29 Compare June 12, 2026 08:45
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch 2 times, most recently from ac7386c to 231cc6b Compare June 15, 2026 01:28
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from c30cd29 to 159f229 Compare June 15, 2026 01:28
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 231cc6b to bc63825 Compare June 15, 2026 09:19
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from 159f229 to 5c01c9b Compare June 15, 2026 09:19
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from bc63825 to e83d44f Compare June 16, 2026 03:59
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch 2 times, most recently from 0291dac to ad8b53f Compare June 16, 2026 09:33
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from e83d44f to 714ff74 Compare June 16, 2026 09:33
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 714ff74 to 30fe84e Compare June 17, 2026 06:27
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from ad8b53f to 30d8fbb Compare June 17, 2026 06:27
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 30fe84e to 82a392e Compare June 18, 2026 01:55
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from 30d8fbb to 70d2e31 Compare June 18, 2026 01:55
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 82a392e to 9c65ca8 Compare June 19, 2026 07:18
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from 70d2e31 to 5fcbe62 Compare June 19, 2026 07:18
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 13.64%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 58 untouched benchmarks
⏩ 9 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation react_compiler[App.tsx] 42.3 ms 33.5 ms +26.2%
Simulation linter[RadixUIAdoptionSection.jsx] 10.1 ms 9 ms +11.51%
Simulation linter[App.tsx] 117.6 ms 107.8 ms +9.12%
Simulation react_compiler[RadixUIAdoptionSection.jsx] 9.1 ms 8.4 ms +8.61%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence (020287d) with 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css (70d2e31)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css (89645c1) during the generation of this report, so 648f514 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from 89645c1 to ab619c7 Compare June 19, 2026 07:45
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 020287d to 37b8466 Compare June 19, 2026 07:45
@leaysgur leaysgur marked this pull request as ready for review June 19, 2026 08:58
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from ab619c7 to b7a6677 Compare June 22, 2026 06:01
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 37b8466 to 8beafbd Compare June 22, 2026 06:01
@leaysgur leaysgur force-pushed the 06-11-feat_oxfmt_format_parser_css_less_scss_files_css-in-js_by_oxc_formatter_css branch from b7a6677 to c1620ef Compare June 23, 2026 02:56
@leaysgur leaysgur force-pushed the 06-11-refactor_oxfmt_use_rust_formatters_for_jsdoc_code_fence branch from 8beafbd to 3b7d98b Compare June 23, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant