Skip to content

refactor(oxfmt): use unified embedded ir results#23325

Open
leaysgur wants to merge 1 commit into
06-12-refactor_oxfmt_remove_prettier_fallback_for_cssfrom
06-12-refactor_oxfmt_use_unified_embedded_ir_results
Open

refactor(oxfmt): use unified embedded ir results#23325
leaysgur wants to merge 1 commit into
06-12-refactor_oxfmt_remove_prettier_fallback_for_cssfrom
06-12-refactor_oxfmt_use_unified_embedded_ir_results

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member
  • Add EmbeddedIr struct in oxc_formatter_core
  • Each format_to_ir implementation returns this as unified result

leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing 06-12-refactor_oxfmt_use_unified_embedded_ir_results (a135199) with main (1c63c66)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 06-12-refactor_oxfmt_remove_prettier_fallback_for_css (e8683d7) during the generation of this report, so main (1c63c66) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from ef3b50d to e20eabf Compare June 12, 2026 07:44
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch 2 times, most recently from 4132591 to 74e46e5 Compare June 12, 2026 07:47
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from 58af702 to ff23826 Compare June 12, 2026 07:58
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 74e46e5 to 845cd47 Compare June 12, 2026 07:58
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from ff23826 to d924eb7 Compare June 12, 2026 08:25
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch 2 times, most recently from 7089ce1 to 9465af4 Compare June 12, 2026 08:45
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from d924eb7 to 81b320c Compare June 12, 2026 08:45
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 15, 2026 01:28
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 81b320c to a204713 Compare June 15, 2026 01:29
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from 9465af4 to 9a272cb Compare June 15, 2026 01:29
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 15, 2026 01:29
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from 9a272cb to 21e3692 Compare June 15, 2026 09:20
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 15, 2026 09:20
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 16, 2026 03:59
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from 21e3692 to 3d822cc Compare June 16, 2026 03:59
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from c51bffb to 04d65ad Compare June 16, 2026 03:59
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 16, 2026 03:59
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 04d65ad to 9c888f3 Compare June 16, 2026 09:33
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 3d822cc to 4337b39 Compare June 16, 2026 09:33
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 17, 2026 06:27
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from 4337b39 to c599e42 Compare June 17, 2026 06:28
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 9c888f3 to 59ea1ba Compare June 17, 2026 06:28
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 17, 2026 06:28
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 18, 2026 01:54
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from c599e42 to dac67a9 Compare June 18, 2026 01:55
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 59ea1ba to 232a8d6 Compare June 18, 2026 01:55
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 18, 2026 01:55
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_remove_prettier_fallback_for_css to graphite-base/23325 June 19, 2026 07:18
@leaysgur leaysgur force-pushed the graphite-base/23325 branch from dac67a9 to fababce Compare June 19, 2026 07:49
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 232a8d6 to 12b5bcd Compare June 19, 2026 07:49
@leaysgur leaysgur changed the base branch from graphite-base/23325 to 06-12-refactor_oxfmt_remove_prettier_fallback_for_css June 19, 2026 07:49
@leaysgur leaysgur marked this pull request as ready for review June 19, 2026 09:07
@leaysgur leaysgur requested a review from Dunqing as a code owner June 19, 2026 09:07
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 12b5bcd to 9b1072f Compare June 22, 2026 06:01
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from fababce to 4532fcf Compare June 22, 2026 06:01
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_remove_prettier_fallback_for_css branch from 4532fcf to e8683d7 Compare June 23, 2026 02:56
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from 9b1072f to a135199 Compare June 23, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant