Skip to content

refactor(ast): add ast_builder Cargo feature#23649

Closed
overlookmotel wants to merge 1 commit into
mainfrom
om/06-06-refactor_ast_add_ast_builder_cargo_feature
Closed

refactor(ast): add ast_builder Cargo feature#23649
overlookmotel wants to merge 1 commit into
mainfrom
om/06-06-refactor_ast_add_ast_builder_cargo_feature

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 19, 2026

Copy link
Copy Markdown
Member

Part of #23043.

Add ast_builder Cargo feature to oxc_ast crate. Feature is enabled by default - no breaking change.

This prepares the way to bring in new AstBuilder implementation.

overlookmotel commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1


Comparing om/06-06-refactor_ast_add_ast_builder_cargo_feature (f40235d) with main (5527bef)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel self-assigned this Jun 19, 2026
@overlookmotel overlookmotel force-pushed the om/06-06-refactor_ast_add_ast_builder_cargo_feature branch 2 times, most recently from faeb137 to 0f7f1c2 Compare June 21, 2026 00:39
@overlookmotel overlookmotel changed the base branch from main to graphite-base/23649 June 23, 2026 00:31
@overlookmotel overlookmotel force-pushed the om/06-06-refactor_ast_add_ast_builder_cargo_feature branch from 0f7f1c2 to f43a323 Compare June 23, 2026 00:31
@overlookmotel overlookmotel changed the base branch from graphite-base/23649 to om/06-21-perf_transformer_object-rest-spread_reduce_iteration June 23, 2026 00:31
@graphite-app graphite-app Bot changed the base branch from om/06-21-perf_transformer_object-rest-spread_reduce_iteration to graphite-base/23649 June 23, 2026 01:02
@graphite-app graphite-app Bot force-pushed the om/06-06-refactor_ast_add_ast_builder_cargo_feature branch from f43a323 to 553197f Compare June 23, 2026 01:08
@graphite-app graphite-app Bot changed the base branch from graphite-base/23649 to main June 23, 2026 01:08
@graphite-app graphite-app Bot force-pushed the om/06-06-refactor_ast_add_ast_builder_cargo_feature branch from 553197f to f40235d Compare June 23, 2026 01:08
@overlookmotel

Copy link
Copy Markdown
Member Author

Superceded by #23743.

@overlookmotel overlookmotel deleted the om/06-06-refactor_ast_add_ast_builder_cargo_feature branch June 23, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant