feat(ast): add custom builder methods to AST types#23651
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
cdf742f to
fc5ec32
Compare
7cab202 to
6a2e997
Compare
6a2e997 to
6143bb3
Compare
fc5ec32 to
9966f70
Compare

Part of #23043.
As well as the generated
AstBuildermethods, we have hand-written convenience methods inast_builder_impl.rs. Replicate these as methods on AST types themselves, using the new genericAstBuildapproach.Note: This stack is draft for now. I'd like to try migrating
oxc_parserto newAstBuilderand check it all works before merging anything.