Repository navigation
Conversation
## What changed A Chrome Web Store install now retries the package download once with the Space's cookies when Google's update service answers 401 or 403. Without this, a private or trusted-tester item can't be installed, because the service serves it only to an account that can see it. The first request still omits cookies, so a public item is downloaded anonymously as before. This matches how Chromium's extension downloader recovers an authenticated CRX fetch (IterateFetchCredentialsAfterFailure). Cancelling the install review still stops the retry. The download's network traffic annotation and the engine README describe when cookies are sent. This touches engine inputs (CrestEngines/Chromium/Overlay), so a maintainer needs to publish a new chromium-engine release with the merge. ## Validation - Scripts/check-version.sh --fix-commit passed (0.8.114 to 0.8.115, release note private-web-store-extension-install). - The Chromium engine was not rebuilt with this change, and installing a private item has not been tried yet. ## AI usage - [x] AI tools helped produce this change. - [x] I ran the `crest-contribution` skill (`.agents/skills/crest-contribution/SKILL.md`), followed it, and reviewed every generated line. ## Boundaries - [x] Space and browsing-profile isolation are preserved. - [x] The macOS and mobile platform behavior remains intentionally native. - [x] User-visible or architecture-significant changes add an explicit entry to `Documentation/ReleaseNotes.json`. - [x] Every verified fix commit includes its patch bump and passes `Scripts/check-version.sh --fix-commit`. - [x] I have signed off every commit as described in `CONTRIBUTING.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: rajuGT <raju.gt@gojek.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Package download and retry flow CrestEngines/Chromium/Overlay/chrome/browser/ui/crest/crest_chrome_host.mm, CrestEngines/Chromium/README.md, Documentation/ReleaseNotes.json, Config/Version.xcconfig |
The download requests the package without cookies and retries once with Space cookies after HTTP 401 or 403. Other unsuccessful responses report an error. The README and release note describe the private extension installation flow, and the marketing version changes to 0.8.115. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Sequence Diagram(s)
sequenceDiagram
participant WebStoreDownload
participant URLLoaderFactory
participant GoogleUpdateService
WebStoreDownload->>URLLoaderFactory: Start anonymous package request
URLLoaderFactory->>GoogleUpdateService: Request package without cookies
GoogleUpdateService-->>WebStoreDownload: Return response
alt HTTP 401 or 403
WebStoreDownload->>URLLoaderFactory: Retry once with Space cookies
URLLoaderFactory->>GoogleUpdateService: Request package with cookies
GoogleUpdateService-->>WebStoreDownload: Return retry response
end
URLLoaderFactory-->>WebStoreDownload: Return file or error
Merge Risk: 
Minimal · up to 01a22
-
No concrete merge-blocking issue is established. A private-extension install remains untested, and the Chromium engine release is still needed after merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Installing a Chrome Web Store item published only to trusted testers or a Workspace domain failed with HTTP 401. Crest downloads the package from Google's update service without cookies, and the service serves such an item only to an account that can see it. The download now asks once more with the Space's cookies when the service refuses with 401 or 403, as Chromium's own extension downloader does. The first request still carries no cookies, so public items download as before, and the retry goes only to Google's service over HTTPS. A refusal's body no longer counts toward the download's progress. Ported from rajuGT's change in #778 to the current Web Store install code. Co-authored-by: rajuGT <2203863+rajuGT@users.noreply.github.com> Signed-off-by: Paul Davis <pauldavis101@gmail.com>
On Chromium, Chrome Web Store extensions published only to trusted testers or a Workspace domain now install, where they failed with HTTP 401 (0.8.188). - Crest downloads the package from Google's update service without cookies, and the service serves such an item only to an account that can see it. - When the service refuses with 401 or 403, the download now asks once more with the Space's cookies, as Chromium's own extension downloader does. The first request still carries no cookies, so public items download as before, and the retry goes only to Google's service over HTTPS. - A refusal's body no longer counts toward the download's progress. This ports rajuGT's change in #778 to the current Web Store install code. Part of the engine stack #974 to #984, which ships with one engine published from the top PR. The engine builds with the change, and a public item still installs in an isolated review build. The retry was not seen to succeed, for want of a private item to install. Host apply, version, public-source, release-note, architecture and license checks and the script tests pass. CI passes. Closes #263 Co-authored-by: rajuGT <2203863+rajuGT@users.noreply.github.com> Signed-off-by: Paul Davis <pauldavis101@gmail.com>
Context
I tried to install a Chrome Web Store extension that's published only to my company's Google Workspace domain. The listing opened, since I'm signed in with an account that can see it, but the install failed with:
This is the problem reported in #263. I used Claude to produce this fix. It would help a lot to have it in a release before Arc's sunset in December; otherwise I'll need another browser for extensions limited to our domain.
What changed
A Chrome Web Store install now retries the package download once with the Space's cookies when Google's update service answers 401 or 403. Without this, a private or trusted-tester item can't be installed, because the service serves it only to an account that can see it. The first request still omits cookies, so a public item is downloaded anonymously as before. This matches how Chromium's extension downloader recovers an authenticated CRX fetch (IterateFetchCredentialsAfterFailure). Cancelling the install review still stops the retry.
The download's network traffic annotation and the engine README describe when cookies are sent.
This touches engine inputs (CrestEngines/Chromium/Overlay), so a maintainer needs to publish a new chromium-engine release with the merge.
Validation
AI usage
crest-contributionskill (.agents/skills/crest-contribution/SKILL.md), followed it, and reviewed every generated line.Boundaries
Documentation/ReleaseNotes.json.Scripts/check-version.sh --fix-commit.CONTRIBUTING.md.Summary by CodeRabbit