i18n(ja): restore literal column names in system-table reference tables - #23396
i18n(ja): restore literal column names in system-table reference tables#23396yahonda wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Restore the literal English column identifiers in the "column name" column of several system-table / SHOW-statement reference tables (they had been translated: オリジナルSQL, プランダイジェスト, 状態, ジョブID, データソース, etc.), row-aligned 1:1 against the English source. Descriptions stay translated, except timestamp descriptions changed 時間→時刻 (作成時刻/更新時刻/最終更新時刻) and a garbled 時間を創る fixed to 作成時刻. Files: sql-plan-management.md, sql-statement-show-bindings/show-import-job/show-stats-meta.md, tidb-lightning-error-resolution.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
b4868fc to
cb83ed2
Compare
The status/phase columns output literal enum values, so keep them in English to match the actual database output and the English source (and the sibling sql-plan-management status row, which already uses English `enabled`/`disabled`/…): - show-bindings status: 「使用中」/「削除済み」/… → `Using` / `Deleted` / `Invalid` / `Rejected` / `Pending verification`. - show-import-job Phase: fix the garbled order and misplaced 含む to `importing`、`validating`、`add-index` を含みます. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
The "column name" column of several system-table /
SHOW-statement reference tables had the literal column identifiers translated into Japanese (e.g.オリジナルSQL,プランダイジェスト,sql_ダイジェスト,状態,作成時間,ソースファイルのサイズ). These are actual database output/column names and must stay as the literal English identifiers.Restored the first column to the literal identifiers, matching the English source and the real column names (descriptions in the second column are left translated):
sql-plan-management.md—original_sql/bind_sql/default_db/status/create_time/update_time/charset/collation/source/sql_digest/plan_digestsql-statements/sql-statement-show-bindings.md— same lower-case identifierssql-statements/sql-statement-show-import-job.md—Status/Source_File_Size/Create_Timesql-statements/sql-statement-show-stats-meta.md—Update_timetidb-lightning/tidb-lightning-error-resolution.md—create_timeDescriptive table headers that merely happen to read like column names (e.g.
文字セット= "Character Set",オリジナル版= "Original version") are not touched — those are normal header translations, not database identifiers.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
i18n-ja-release-8.5machine-translation cleanup series. Note:sql-plan-management.mdis also edited by the dropped-text PR on nearby table rows (different column), so whichever merges second needs a trivial one-file rebase.AI agent involvement
Do your changes match any of the following descriptions?