Skip to content

i18n(ja): restore literal column names in system-table reference tables - #23396

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-column-name-identifiers
Open

i18n(ja): restore literal column names in system-table reference tables#23396
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-column-name-identifiers

Conversation

@yahonda

@yahonda yahonda commented Jul 31, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The "column name" column of several system-table / SHOW-statement reference tables had the literal column identifiers translated into Japanese (e.g. オリジナルSQL, プランダイジェスト, sql_ダイジェスト, 状態, 作成時間, ソースファイルのサイズ). These are actual database output/column names and must stay as the literal English identifiers.

Restored the first column to the literal identifiers, matching the English source and the real column names (descriptions in the second column are left translated):

  • sql-plan-management.mdoriginal_sql / bind_sql / default_db / status / create_time / update_time / charset / collation / source / sql_digest / plan_digest
  • sql-statements/sql-statement-show-bindings.md — same lower-case identifiers
  • sql-statements/sql-statement-show-import-job.mdStatus / Source_File_Size / Create_Time
  • sql-statements/sql-statement-show-stats-meta.mdUpdate_time
  • tidb-lightning/tidb-lightning-error-resolution.mdcreate_time

Descriptive table headers that merely happen to read like column names (e.g. 文字セット = "Character Set", オリジナル版 = "Original version") are not touched — those are normal header translations, not database identifiers.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese-only fix; no English source change)
  • Other reference link(s): part of the i18n-ja-release-8.5 machine-translation cleanup series. Note: sql-plan-management.md is also edited by the dropped-text PR on nearby table rows (different column), so whichever merges second needs a trivial one-file rebase.

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af72648d-7195-4a30-a344-51a8b25603da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2026
Restore the literal English column identifiers in the "column name" column of
several system-table / SHOW-statement reference tables (they had been
translated: オリジナルSQL, プランダイジェスト, 状態, ジョブID, データソース, etc.),
row-aligned 1:1 against the English source. Descriptions stay translated,
except timestamp descriptions changed 時間→時刻 (作成時刻/更新時刻/最終更新時刻)
and a garbled 時間を創る fixed to 作成時刻. Files: sql-plan-management.md,
sql-statement-show-bindings/show-import-job/show-stats-meta.md,
tidb-lightning-error-resolution.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-restore-column-name-identifiers branch from b4868fc to cb83ed2 Compare July 31, 2026 05:24
The status/phase columns output literal enum values, so keep them in English
to match the actual database output and the English source (and the sibling
sql-plan-management status row, which already uses English `enabled`/`disabled`/…):
- show-bindings status: 「使用中」/「削除済み」/… → `Using` / `Deleted` / `Invalid` /
  `Rejected` / `Pending verification`.
- show-import-job Phase: fix the garbled order and misplaced 含む to
  `importing`、`validating`、`add-index` を含みます.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant