i18n(ja): fix dropped particles before common action verbs - #23579
i18n(ja): fix dropped particles before common action verbs#23579yahonda wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
missing-translation-status
|
|
ti-chi-bot
Bot
added
area/develop
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request corrects Japanese documentation across guides, FAQs, configuration procedures, TiCDC and TiDB Cloud instructions, troubleshooting pages, examples, and historical release notes. It changes wording, grammar, punctuation, spacing, and sample labels only. ChangesDocumentation wording corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to The PR improves Japanese documentation across many files, but the current head still contains unresolved instructions that could lead users to invalid Terraform settings, incorrect configuration guidance, or misleading routing behavior, along with several localized clarity and formatting issues. Merge should wait for these concrete documentation issues to be corrected or explicitly accepted. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
size/XL
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 31
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1d496976-e553-476a-ace9-bbdd848c92a2
📒 Files selected for processing (79)
accelerated-table-creation.mdai/guides/auto-embedding.mdai/guides/vector-search.mdalert-rules.mdbest-practices/ddl-introduction.mdbest-practices/index-management-best-practices.mdbest-practices/multi-column-index-best-practices.mdbest-practices/pd-scheduling-best-practices.mdbest-practices/tidb-best-practices.mdbr/br-incremental-guide.mdcheck-before-deployment.mdclinic/clinic-user-guide-for-tiup.mdclinic/quick-start-with-clinic.mdcost-model.mddashboard/dashboard-session-sso.mddevelop/dev-guide-schema-design-overview.mddm/dm-online-ddl-tool-support.mddr-multi-replica.mddr-secondary-cluster.mdfaq/backup-and-restore-faq.mdfaq/deploy-and-maintain-faq.mdfaq/migration-tidb-faq.mdfaq/upgrade-faq.mdhybrid-deployment-topology.mdoptimizer-fix-controls.mdperformance-tuning-methods.mdreleases/release-2.1-beta.mdreleases/release-2.1-ga.mdreleases/release-2.1-rc.3.mdreleases/release-2.1.15.mdreleases/release-3.0-beta.mdreleases/release-3.0-ga.mdreleases/release-3.0.0-beta.1.mdreleases/release-3.0.0-rc.1.mdreleases/release-3.0.1.mdreleases/release-3.0.3.mdreleases/release-3.0.4.mdreleases/release-4.0.12.mdreleases/release-4.0.2.mdreleases/release-4.0.3.mdreleases/release-5.0.0-rc.mdreleases/release-5.0.6.mdreleases/release-6.3.0.mdreleases/release-6.5.9.mdreleases/release-7.1.5.mdreleases/release-7.4.0.mdreleases/release-7.5.2.mdscale-tidb-using-tiup.mdsecurity-compatibility-with-mysql.mdsql-statements/sql-statement-alter-table-compact.mdsql-statements/sql-statement-savepoint.mdstorage-engine/titan-configuration.mdsync-diff-inspector/route-diff.mdticdc/deploy-ticdc.mdticdc/integrate-confluent-using-ticdc.mdticdc/ticdc-bidirectional-replication.mdticdc/ticdc-client-authentication.mdticdc/ticdc-faq.mdticdc/ticdc-open-protocol.mdticdc/troubleshoot-ticdc.mdtidb-cloud/monitor-new-relic-integration.mdtidb-cloud/scale-tidb-cluster.mdtidb-cloud/serverless-private-link-connection-to-amazon-msk.mdtidb-cloud/set-up-private-endpoint-connections.mdtidb-cloud/setup-azure-self-hosted-kafka-private-link-service.mdtidb-cloud/terraform-use-cluster-resource.mdtidb-cloud/terraform-use-dedicated-cluster-resource.mdtidb-cloud/terraform-use-import-resource.mdtidb-cloud/terraform-use-restore-resource.mdtidb-cloud/ticloud-serverless-spending-limit.mdtidb-performance-tuning-config.mdtiflash/tiflash-configuration.mdtiflash/tiflash-disaggregated-and-s3.mdtikv-control.mdtiproxy/tiproxy-load-balance.mdtiup/customized-montior-in-tiup-environment.mdtiup/tiup-cluster-no-sudo-mode.mdtransaction-overview.mdtroubleshoot-data-inconsistency-errors.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 55911f12-1437-4948-a860-7d6ed5bf5721
📒 Files selected for processing (1)
best-practices/multi-column-index-best-practices.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 5
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 282e0d5a-66af-4a7f-b2e2-8a5034439c75
📒 Files selected for processing (22)
best-practices/multi-column-index-best-practices.mdbr/br-incremental-guide.mdclinic/clinic-user-guide-for-tiup.mdclinic/quick-start-with-clinic.mddevelop/dev-guide-schema-design-overview.mddm/dm-online-ddl-tool-support.mdfaq/upgrade-faq.mdhybrid-deployment-topology.mdperformance-tuning-methods.mdreleases/release-2.1-ga.mdreleases/release-2.1-rc.3.mdreleases/release-3.0.0-rc.1.mdreleases/release-3.0.4.mdreleases/release-4.0.3.mdreleases/release-5.0.0-rc.mdreleases/release-5.0.6.mdscale-tidb-using-tiup.mdsql-statements/sql-statement-alter-table-compact.mdticdc/ticdc-faq.mdtidb-cloud/scale-tidb-cluster.mdtiflash/tiflash-configuration.mdtiflash/tiflash-disaggregated-and-s3.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
qiancai
added
translation/no-need
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
aa2efb0 to
c283d04
Compare
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
3301940 to
4cc1649
Compare
55 sites across 51 files where the topic particle は appears to be missing immediately after a code span/bracket, before a definitional or state predicate (becomes/is called/represents/corresponds to/is supported/etc.). NOT individually verified against the English source per-site, unlike the previous を (#23579/#23611) and が (#23624) sweeps. は is far more context-dependent than を/が (Japanese frequently and correctly omits は when a topic is already established), so a mechanical detector has a much higher false-positive rate here. Submitted as a draft specifically so a human can review each site before merging. UPDATE: user review caught a systemic false-positive class in the になります/となります predicate category (18 sites) -- the captured code span/bracket is the COMPLEMENT (the resulting value) of the "becomes X" predicate, not its subject, e.g. "この機能が一般提供 （GA）となります" (the feature becomes GA) mis-edited to insert は right before となります, producing the ungrammatical "一般提供（GA） はとなります". All 18 sites in this predicate category were reverted; 37 sites across the other predicate categories remain.
Rebased onto i18n-ja-release-8.5 after pingcap#23602 merged the markdownlint conformance fixes and after pingcap#23577's katakana compound-word joins. Re-verified and restored 8 katakana joins that had been silently reverted by the initial content-preserving merge on lines this branch also touched, using an independent scan comparing spaced-katakana runs in the result against upstream's already-joined form.
4cc1649 to
72420e8
Compare
…l-fix-dropped-particles-review-2026-08-20 # Conflicts: # dr-multi-replica.md # faq/upgrade-faq.md # performance-tuning-methods.md # releases/release-3.0-beta.md # tiproxy/tiproxy-load-balance.md
2 participants
What is changed, added or deleted? (Required)
Scanned the corpus for a high-confidence dropped-particle pattern: a closing code-span backtick, bracket, or parenthesis immediately followed (no space, no particle) by a common transitive action verb (設定します/して, 追加します/して, 選択します/して, 使用します/して, 確認します/して, 比較します/して, 変更します/して, 削除します/して, 入力します/して, 指定します/して, 表示します/して, 実行します/して, 作成します/して, クリックします/して). In Japanese, these verbs require a を particle marking their object, e.g.
`X`設定しますshould be`X`を設定します("configure/set X").Verified a representative sample against the English source before applying: all confirmed genuine drops (e.g. "add
Xto the end of the file" ->Xを追加します, "directly selectsIndex_A" ->Index_Aを選択します).Found and corrected 9 cases where the naive insertion created a double を, because the code span was in apposition to a noun already marked を earlier in the same clause (e.g. "監視項目を
X追加します" = "add the monitoring item, X" - only one を needed, not two) or needed に instead of a second を (`region`を`US`に設定します= "set region TO US", not "region-WO US-WO").Also fixed, found during manual review of the affected lines:
best-practices/tidb-best-practices.md: removed a redundant repeated word after a link ("[グローバルインデックス]インデックスでもある" -> "[グローバルインデックス]でもある"), matching the established leading/trailing-word-duplication defect class.tidb-cloud/setup-azure-self-hosted-kafka-private-link-service.md: fixed a pre-existing bold/bracket straddling defect on the same line ("[サブスクリプション]" -> "[サブスクリプション]", "[名前]" -> "[名前]").123 particle insertions across 79 files (net, after the 9 corrections and 2 bonus fixes). Verified 0 anomalies in line-count/backtick-count/
[-count/]-count across all 76 changed files.Scope note: this uses a specific, high-confidence heuristic (code-span/bracket immediately followed by one of these verbs with zero intervening characters). It is not an exhaustive review of every possible dropped particle in the corpus — other dropped-particle shapes (e.g. missing が/は, or drops not adjacent to a code span) are not covered here and would need separate detection heuristics.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit