refactor(status): rename blocked → waiting and blocked_api → rate_limited#430
Open
refactor(status): rename blocked → waiting and blocked_api → rate_limited#430
Conversation
…ited (orch-449) Rename run statuses across the entire codebase for clarity: - blocked → waiting (run is idle, waiting for user input) - blocked_api → rate_limited (run hit API rate limit) Backward compatibility preserved via NormalizeStatus/NormalizeRunStatus shims that accept both old and new names. Proto numeric IDs unchanged (4 and 5). Historical vault data untouched. Changes span: Go constants, proto definitions, CLI flags/help, daemon logic, config compat, Python TUI, VSCode extension, tests, and all documentation (~89 files). Closes: orch-449
f8d0a52 to
c8ff2a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename run statuses
blocked→waitingandblocked_api→rate_limitedacross the entire orch codebase for clarity. "Blocked" was misleading for both users and LLM agents — it implies an error when the run is simply idle awaiting input.Closes: orch-449
Changes
Core (Go)
RUN_STATUS_WAITING = 4,RUN_STATUS_RATE_LIMITED = 5(numeric IDs preserved)StatusBlocked/StatusBlockedAPIidentifiers renamedNormalizeStatus()andNormalizeRunStatus()map old names → newmodel.Status(string)casts replaced withNormalizeStatus()(6+ sites)ShouldNotify()andvalidSlackNotifyStatusesaccept both old+new names--only-blocked→--only-waiting, display abbrevs"wait"/"rlimit"stringToProtoRunStatusaccepts both;protoRunStatusToStringoutputs new onlyPython TUI
VSCode Extension
runsProvider.tscase statements +package.jsonenum schemaTests
NormalizeStatusandNormalizeRunStatus"status:waiting"label mappingDocumentation
Backward Compatibility
NormalizeStatus("blocked")→StatusWaiting— no migration needednotify_on: [blocked]continues to workstatus:blockedstill maps correctlywaiting/rate_limitedVerification
go build ./...passesgo test ./...passes (1 pre-existing failure inTestApplyConfigDefaultsFallbacksunrelated to this PR)make lintpasses (semgrep architecture rules)StatusBlockedidentifiers remain"blocked"string literals are in compat shim code, config compat, or tests only| status | blockedto verify compat parsing