Skip to content

Add tests isolation for rmw_zenoh#1291

Closed
JEnoch wants to merge 4 commits intoros2:rollingfrom
JEnoch:tests_isolation_for_zenoh
Closed

Add tests isolation for rmw_zenoh#1291
JEnoch wants to merge 4 commits intoros2:rollingfrom
JEnoch:tests_isolation_for_zenoh

Conversation

@JEnoch
Copy link
Copy Markdown

@JEnoch JEnoch commented Feb 16, 2026

Description

As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation:

  • in rcl_action using ament_add_ros_isolated_gtest_test in CMakeLists.txt
  • in rcl/test_rmw_impl_id_check setting ZENOH_CONFIG_OVERRIDE to not attempt connection to any router.

Is this user-facing behavior change?

No

Did you use Generative AI?

No

@JEnoch JEnoch force-pushed the tests_isolation_for_zenoh branch from 736c576 to ffcded4 Compare February 16, 2026 16:58
fujitatomoya
fujitatomoya reviewed Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm.

  • we need to rebase this dev branch to build.
  • a couple of minor comments to be resolved.

JEnoch and others added 4 commits February 17, 2026 10:10
@JEnoch
Add tests isolation in rcl_action
98f786f 
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
@JEnoch
test_rmw_impl_id_check: in case of rmw_zenoh_cpp don't connect to Zen…
6f521e6 
…oh router

Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
@JEnoch @fujitatomoya
Update rcl/test/rcl/test_rmw_impl_id_check.py.in
da7b16c 
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
@JEnoch @fujitatomoya
Update rcl/test/rcl/test_rmw_impl_id_check.py.in
3f63083 
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
@JEnoch JEnoch force-pushed the tests_isolation_for_zenoh branch from c7467c3 to 3f63083 Compare February 17, 2026 09:10
@JEnoch
Copy link
Copy Markdown
Author

JEnoch commented Feb 17, 2026

Done. Thanks for your review!

I guess the failing build caused by fatal error: rcutils/base64.h: No such file or directory is due to ros2/rcutils#533 not available yet in rolling libs.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 17, 2026

Pulls: #1291
Gist: https://gist.githubusercontent.com/fujitatomoya/90d8bb8ac1929c8f147b96e92fea7de4/raw/986a916b3d6ee0e010e7882bba1d49fa0a21f3ec/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action
TEST args: --packages-above rcl rcl_action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18216

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@JEnoch JEnoch mentioned this pull request Feb 18, 2026
Open
@JEnoch
Copy link
Copy Markdown
Author

JEnoch commented Feb 26, 2026

Are we waiting for ros-rolling-rcutils 0.7.6 package to be available in the repo ?
Or is there anything else I should do for this PR to be merged ?

@JEnoch JEnoch mentioned this pull request Mar 10, 2026
Merged
@JEnoch
Copy link
Copy Markdown
Author

JEnoch commented Apr 13, 2026

Superseded by #1311

@JEnoch JEnoch closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

Assignees

@mjcarroll mjcarroll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JEnoch @fujitatomoya @mjcarroll