Improve and refactor method to search for stored block in mainchain#574
Open
julia-zack wants to merge 2 commits into
Open
Improve and refactor method to search for stored block in mainchain#574julia-zack wants to merge 2 commits into
julia-zack wants to merge 2 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
julia-zack
force-pushed
the
improve-stored-blocks-search
branch
from
9a750be to
609ced7
Compare
julia-zack
commented
May 20, 2026
| verify(btcToRskClientFileStorageMock, times(1)).write(any()); | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
removed all pre-rskip89 tests
julia-zack
changed the base branch from
powpeg-refactors-integration
to
fix-constant-declaration
julia-zack
force-pushed
the
improve-stored-blocks-search
branch
from
609ced7 to
6ab2275
Compare
Base automatically changed from
fix-constant-declaration
to
powpeg-refactors-integration
May 20, 2026 19:30
julia-zack
commented
May 21, 2026
Comment on lines
-388
to
-389
| long bestBlockNumber = federatorSupport.getRskBestChainHeight(); | ||
| boolean useBlockDepth = activationConfig.isActive(ConsensusRule.RSKIP89, bestBlockNumber); |
Contributor
Author
There was a problem hiding this comment.
no need to check for activations
julia-zack
commented
May 21, 2026
| return Optional.empty(); | ||
| } | ||
|
|
||
| private StoredBlock findBridgeBtcBlockchainMatchingAncestorUsingBlockLocator() throws BlockStoreException { |
Contributor
Author
There was a problem hiding this comment.
removed since only being used pre rskip89
marcos-iov
force-pushed
the
powpeg-refactors-integration
branch
3 times, most recently
from
1177ea8 to
a835abe
Compare
…Remove RSKIP89 activation check
marcos-iov
force-pushed
the
improve-stored-blocks-search
branch
from
4063ea3 to
4defc6d
Compare
|
marcos-iov
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve and refactor method to search for stored block in mainchain and remove RSKIP89 activation check