Skip to content

Improve and refactor method to search for stored block in mainchain #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julia-zack wants to merge 2 commits into
base: powpeg-refactors-integration
Choose a base branch
from

Added test to check appearance hashes from non-stubed blocks are just…

4defc6d
Select commit
Loading
Failed to load commit list.
Open

Improve and refactor method to search for stored block in mainchain #574

Added test to check appearance hashes from non-stubed blocks are just…
4defc6d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 21, 2026 in 47s

Quality Gate passed

Issues
31 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.8% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 119 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT5&open=AZ5G1vUJstnyi3a5fIT5&pullRequest=574

Check warning on line 89 in src/test/java/co/rsk/federate/signing/hsm/client/HSMClientProtocolTestUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vVpstnyi3a5fIUM&open=AZ5G1vVpstnyi3a5fIUM&pullRequest=574

Check warning on line 124 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT6&open=AZ5G1vUJstnyi3a5fIT6&pullRequest=574

Check warning on line 81 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT0&open=AZ5G1vUJstnyi3a5fIT0&pullRequest=574

Check warning on line 108 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT4&open=AZ5G1vUJstnyi3a5fIT4&pullRequest=574

Check warning on line 87 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT1&open=AZ5G1vUJstnyi3a5fIT1&pullRequest=574

Check warning on line 128 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT7&open=AZ5G1vUJstnyi3a5fIT7&pullRequest=574

Check warning on line 80 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fITz&open=AZ5G1vUJstnyi3a5fITz&pullRequest=574

Check failure on line 593 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if/for/while/switch/try statements. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vU6stnyi3a5fIUF&open=AZ5G1vU6stnyi3a5fIUF&pullRequest=574

Check warning on line 66 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fITx&open=AZ5G1vUJstnyi3a5fITx&pullRequest=574

Check warning on line 56 in src/test/java/co/rsk/federate/signing/hsm/client/HSMClientProtocolTestUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vVpstnyi3a5fIUJ&open=AZ5G1vVpstnyi3a5fIUJ&pullRequest=574

Check warning on line 94 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT2&open=AZ5G1vUJstnyi3a5fIT2&pullRequest=574

Check warning on line 131 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT8&open=AZ5G1vUJstnyi3a5fIT8&pullRequest=574

Check warning on line 297 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vVfstnyi3a5fIUI&open=AZ5G1vVfstnyi3a5fIUI&pullRequest=574

Check warning on line 556 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vU6stnyi3a5fIUG&open=AZ5G1vU6stnyi3a5fIUG&pullRequest=574

Check warning on line 57 in src/test/java/co/rsk/federate/signing/hsm/client/HSMClientProtocolTestUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vVpstnyi3a5fIUK&open=AZ5G1vVpstnyi3a5fIUK&pullRequest=574

Check warning on line 58 in src/test/java/co/rsk/federate/signing/hsm/client/HSMClientProtocolTestUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vVpstnyi3a5fIUL&open=AZ5G1vVpstnyi3a5fIUL&pullRequest=574

Check warning on line 411 in src/test/java/co/rsk/federate/signing/hsm/advanceblockchain/HsmBookkeepingClientImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "put"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vWBstnyi3a5fIUN&open=AZ5G1vWBstnyi3a5fIUN&pullRequest=574

Check warning on line 137 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT-&open=AZ5G1vUJstnyi3a5fIT-&pullRequest=574

Check warning on line 149 in src/main/java/co/rsk/federate/PegUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUYstnyi3a5fIUC&open=AZ5G1vUYstnyi3a5fIUC&pullRequest=574

Check warning on line 143 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIUA&open=AZ5G1vUJstnyi3a5fIUA&pullRequest=574

Check warning on line 22 in src/main/java/co/rsk/federate/signing/hsm/requirements/ReleaseRequirementsEnforcer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vTUstnyi3a5fITw&open=AZ5G1vTUstnyi3a5fITw&pullRequest=574

Check warning on line 580 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vU6stnyi3a5fIUD&open=AZ5G1vU6stnyi3a5fIUD&pullRequest=574

Check warning on line 95 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT3&open=AZ5G1vUJstnyi3a5fIT3&pullRequest=574

Check warning on line 140 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ5G1vUJstnyi3a5fIT_&open=AZ5G1vUJstnyi3a5fIT_&pullRequest=574
View more details on SonarQubeCloud