Skip to content

Follow device appearance or keep a Light / Black preference - #1194

Closed
zxxma wants to merge 5 commits into
mainfrom
feat/system-theme-preference
Closed

zxxma wants to merge 5 commits into
mainfrom
feat/system-theme-preference

Conversation

@zxxma

@zxxma zxxma commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Device appearance was only read at startup, and the UI offered no way to return to System after a manual choice. Add System / Light / Black in the desktop top bar, mobile More menu and Settings, with ongoing OS synchronization, cross-tab updates and safe storage fallback. Preserve existing dark/light values and the resolved CSS-theme contract.

This is the theme foundation for the professional-mainnet pilot in #1186. Validators palette/layout work remains a separate default-off PR (#1195). No network, contract or authentication flags change. The branch incorporates mainline d49896a and preserves the landed validator accessibility and protobuf changes.

Test plan

  • Final branch d3028e8 passes full GitHub CI: Node 20/22 frontend, full Chromium E2E, mobile guardrails, backend, Docker, workspace and protobuf checks.
  • Initial local full frontend suite: 503 files / 5,002 tests passed, one existing skip. Refreshed local production build/lint passed; the duplicate local unit rerun was stopped once equivalent exact-branch CI passed.
  • Dedicated Chromium theme behavior test passed: OS following, manual override/reload and returning to System.
  • All 20 local iPhone shell/validator guardrails passed after removing the redundant mobile top-bar picker, retaining More/Settings. Includes the new 320px header and More-menu case.
  • The desktop network-picker test now targets its accessible name so adding a separate theme picker does not make the locator ambiguous; all three affected local top-bar tests passed, followed by green full desktop CI.
  • Full backend build/race suite and Buf lint passed before the final frontend-only mainline refresh; final remote CI also passes these checks.

Draft for review; no automatic merge or deployment.

@netlify

netlify Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for memba-multisig ready!

Name Link
🔨 Latest commit d3028e8
🔍 Latest deploy log https://app.netlify.com/projects/memba-multisig/deploys/6aa854076efdd90007e37dc5
😎 Deploy Preview https://deploy-preview-1194--memba-multisig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 83 (no change from production)
SEO: 90 (no change from production)
PWA: 100 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow CI / proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 14, 2026, 8:07 PM

@zxxma

zxxma commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #1200 (professional frontend design rollout), which shipped the theme preference work on main; this branch now conflicts in 9 files. The branch is kept for reference.

@zxxma zxxma closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant