Complete the professional frontend design rollout - #1200
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / proto (pull_request).
|
zxxma
marked this pull request as ready for review
September 15, 2026 09:05
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the approved professional frontend across 83 representative route paths: Folded M branding, system-default Light and true Black themes, readable typography, wider workspaces, responsive forms and collections, and clearer governance and transaction review. Consolidates #1194–#1197 and the audit from #1186.
The final owner feedback is included:
The full route review also found and fixed a pre-existing Dev Report cache-restoration crash. Only successful Dev Report queries are now persisted; the incompatible old cache format is discarded before hydration. Cached read data refetches once. Wallet and transaction storage is unaffected. Regression tests reproduce the original exception and verify both the corrected storage round trip and migration.
Review
Screenshots use labelled deterministic fixtures. No real transaction was signed or broadcast. The exact deployment link avoids an older service-worker cache on the reusable preview URL. The deployment above is ready for
60fae9d7; its App Store renders all six ecosystem links and the sun/moon theme control.Integration and release boundaries
f8302d49is integrated, including Count every arcade broadcast attempt toward the cycle limit #1202 (arcade broadcast attempt cap), chore(deps): bump connectrpc.com/connect from 1.20.0 to 1.21.0 in /backend in the connectrpc group across 1 directory #1189 (Go Connect update) and chore(deps): bump the connectrpc group across 1 directory with 2 updates #1192 (ConnectRPC frontend dependencies). Both integrations merged without conflicts. The design source is unchanged; the final update adopts main’s new dependency lockfile. The final read-only check found 26 worktrees: this PR worktree and 24 others are clean;fix-dao-creation-recoveryhas ongoing uncommitted work in its own checkout, which was left untouched. Its unfinished changes are not included in this PR. Other sessions’ working trees were not modified.VITE_ENABLE_PRO_APP=trueenables the full design in Deploy Previews. Production presentation activation and contract deployment remain separate release decisions. Navigation wording, the ecosystem directory and Coming soon content are shared by default and professional builds.Test plan
Final verified head:
60fae9d71e9be94dd1aeb4b875af22b2ada32d05. All required checks passed on this head: 24 successful checks and one informational Netlify page-diff result. Build, lint and 17 focused regression tests also passed locally with the updated dependencies.Node 20 and 22: build, lint and 5,171 unit tests passed, with 15 existing skips.
Full design: 61 route/accessibility cases + 33 feature cases passed, followed by the full-design build.
Professional regressions: 36 Validators + 37 shell/brand + 42 governance cases passed across the configured browsers.
Legacy Chromium: 230 passed, seven existing skips; mobile guardrails also passed.
Backend/race, Gno, workspace, protocol, Docker and security checks passed; the exact final deployment is ready.
The cache regression additionally passed two focused unit tests and eight repeated route-group checks covering both themes and desktop/mobile sizes, without suppressing browser errors.
The integrated arcade fix passed its focused race suite locally. The local full backend run hit the machine’s unaccepted Xcode license; the complete Linux CI race suite passed.