fix: non-jumping menu-bar clock via monospaced digits#11
Open
Wegi wants to merge 1 commit into
Open
Conversation
Wegi
force-pushed
the
feat/issue-6-stable-clock
branch
from
c8e8dc7 to
281e2af
Compare
Wegi
force-pushed
the
feat/issue-9-hhmm-display
branch
from
3e9547a to
e72fa7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
What
The ticking menu-bar clock no longer shifts in width as digits change.
How
Two pieces together fix the jumping:
hh:mm, zero-padded)..monospacedDigit()to the menu-barText, so every digit occupies the same width (01:11is exactly as wide as00:00).The popover's main-project clock already uses a monospaced design and the side-project/report rows already use
monospacedDigit()— untouched.Tests
Pure view modifier (app target, not unit-testable). Verified by building; visual check: menu-bar width stays fixed while ticking.
Stack note: stacked on #10 (base branch
feat/issue-9-hhmm-display); merge #10 first, then this.