Depicting deletions with plotsr - #100
Merged
Merged
Conversation
lrauschning
approved these changes
Jul 24, 2026
lrauschning
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the long radio silence, Manish left the lab and plotsr maintenance has been a bit chaotic.
The changes look good, I'll look for a way to get the CLI thing working as well and then merge.
Contributor
|
Merging, CI on python 3.11 seems to be a bit broken |
Contributor
|
Thanks for the improvement @ira-zibbu :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Long-time user of plotsr, and I enjoy the visualizations it generates. However one feature I have long wanted was to also depict deletions in the synteny plots with a dedicated ribbon. Here I have minimally update the code to enable this.
This PR introduces the ability to depict deletions with a dedicated ribbon.
Currently, deletions are not depicted in the synteny plots.
Deletion mutations (with the key 'DEL') are depicted with red ribbons. See the following example from two E. coli genomes:
To the best of my knowledge this should not break the application. The provided test ran successfully.
The main CLI in
plotsr.pycontains options to disable depicting certain kinds of mutations.I was unable to figure out how these options are used by the script to introduce flexibility in depictions. I propose than an option also be included for deletions, to allow the user to disable depicting deletions if that behaviour is not required.