Skip to content

switch to c++17 - #582

Merged
simonfuhrmann merged 4 commits into
simonfuhrmann:masterfrom
simogasp:ci/switch_c++17
Nov 3, 2025
Merged

simonfuhrmann merged 4 commits into
simonfuhrmann:masterfrom
simogasp:ci/switch_c++17

Conversation

@simogasp

@simogasp simogasp commented Nov 3, 2025 •

Copy link
Copy Markdown
Contributor

Switch to c++17 standard as recent versions of GTest require it. The CI on macos was failing because homebrew pulls such versions.

Incidentally,

  • added permissions to the workflow
  • set a monthly schedule for automatically triggering the workflow

# every 1st day of month at 00:00 UTC
- cron: "0 0 1 * *"

permissions:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this section to me? Why does this workflow need non-default permissions? What does checks: write and pull-requests: write mean?

@simogasp simogasp Nov 3, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, it's a best practice to make the permissions explicit (https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/)
What I did wrong here is a bad copy-paste from another repo of mine in which I had codecov and dependabot that required the write permissions.

Sorry about that, I will fix it to be read-only, unless you are planning to use any tools like that.

Also, if you agree, I'd remove the old pipelines like ubuntu 20.04 and macos 13 as they either fail while setting up (macos) or get stuck. You can see it on my fork here
https://github.com/simogasp/mve/actions/runs/19043320892

@simonfuhrmann
simonfuhrmann merged commit 48a69d0 into simonfuhrmann:master Nov 3, 2025
6 checks passed
@simonfuhrmann

Copy link
Copy Markdown
Owner

Thanks.

@simogasp
simogasp deleted the ci/switch_c++17 branch November 3, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants