Skip to content

switch to c++17 #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonfuhrmann merged 4 commits into from
Nov 3, 2025
Merged

switch to c++17 #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c301bc
switch to c++17 for gtest to compile
simogasp Nov 3, 2025
55ee8bf
[co] Add workflow dispatch and schedule to CI configuration monthly t…
simogasp Nov 3, 2025
60c8f67
[ci] fix the permissions to default
simogasp Nov 3, 2025
40cf5a4
[ci] removed obsolete platforms
simogasp Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ on:
branches: [ "master" ]
pull_request:
branches: [ "master" ]
workflow_dispatch:
schedule:
# every 1st day of month at 00:00 UTC
- cron: "0 0 1 * *"

permissions:

@simonfuhrmann simonfuhrmann Nov 3, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this section to me? Why does this workflow need non-default permissions? What does checks: write and pull-requests: write mean?

@simogasp simogasp Nov 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, it's a best practice to make the permissions explicit (https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/)
What I did wrong here is a bad copy-paste from another repo of mine in which I had codecov and dependabot that required the write permissions.

Sorry about that, I will fix it to be read-only, unless you are planning to use any tools like that.

Also, if you agree, I'd remove the old pipelines like ubuntu 20.04 and macos 13 as they either fail while setting up (macos) or get stuck. You can see it on my fork here
https://github.com/simogasp/mve/actions/runs/19043320892

contents: read
checks: read
pull-requests: read

jobs:
build:
Expand All @@ -16,13 +25,10 @@ jobs:

matrix:
platform:
- { name: "Ubuntu 20.04, GCC, x86_64", os: ubuntu-20.04, cpp_compiler: g++, qmake_spec: linux-g++ }
- { name: "Ubuntu 20.04, Clang, x86_64", os: ubuntu-20.04, cpp_compiler: clang++, qmake_spec: linux-clang }
- { name: "Ubuntu 22.04, GCC, x86_64", os: ubuntu-22.04, cpp_compiler: g++, qmake_spec: linux-g++ }
- { name: "Ubuntu 22.04, Clang, x86_64", os: ubuntu-22.04, cpp_compiler: clang++, qmake_spec: linux-clang }
- { name: "Ubuntu 24.04, GCC, x86_64", os: ubuntu-24.04, cpp_compiler: g++, qmake_spec: linux-g++ }
- { name: "Ubuntu 24.04, Clang, x86_64", os: ubuntu-24.04, cpp_compiler: clang++, qmake_spec: linux-clang }
- { name: "macOS 13, Clang, x86_64", os: macos-13, cpp_compiler: clang++, qmake_spec: macx-clang }
- { name: "macOS 14, Clang, arm64", os: macos-14, cpp_compiler: clang++, qmake_spec: macx-clang }
- { name: "macOS 15, Clang, arm64", os: macos-15, cpp_compiler: clang++, qmake_spec: macx-clang }

Expand Down
2 changes: 1 addition & 1 deletion Makefile.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
CXX ?= g++
CXXWARNINGS ?= -Wall -Wextra -Wundef -pedantic
CXXINTRINSICS ?= -march=native
CXXFEATURES ?= -funsafe-math-optimizations -fno-math-errno -std=c++14
CXXFEATURES ?= -funsafe-math-optimizations -fno-math-errno -std=c++17
CXXFLAGS ?= ${CXXWARNINGS} ${CXXINTRINSICS} ${CXXFEATURES} -g -O3

# Delete this if OpenMP is not available (e.g., OS X without gcc)
Expand Down
2 changes: 1 addition & 1 deletion tests/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GTEST_LDFLAGS = `pkg-config --libs gtest_main`
SOURCES = $(wildcard math/gtest_*.cc) $(wildcard mve/gtest_*.cc) $(wildcard sfm/gtest_*.cc) $(wildcard util/gtest_*.cc) $(wildcard fssr/gtest_*.cc)
INCLUDES = -I${MVE_ROOT}/libs ${GTEST_CFLAGS}
CXXWARNINGS = -Wall -Wextra -pedantic -Wno-sign-compare
CXXFLAGS = -std=c++14 -pthread ${CXXWARNINGS} ${INCLUDES}
CXXFLAGS = -std=c++17 -pthread ${CXXWARNINGS} ${INCLUDES}
LDLIBS += ${GTEST_LDFLAGS} ${LIBJPEG_LDFLAGS} ${LIBPNG_LDFLAGS} ${LIBTIFF_LDFLAGS}

test: ${SOURCES:.cc=.o} libmve_fssr.a libmve_sfm.a libmve.a libmve_util.a
Expand Down