Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940.
Skip a leading UTF-8 BOM when checking the input sample for a JSON array or object. The original bytes still go through the JSON reader, and CSV dialect detection uses its existing input. Regression cases cover a JSON array, a JSON object after a newline, and a CSV control.
On macOS/Python 3.12, both new JSON cases reproduced the bug before the fix. After the fix, 51 targeted tests passed. A full local offline run passed 1,500 tests and skipped 16 optional tests that require the compiled SQLite example extension, SpatiaLite, or NumPy/pandas. Black, flake8, mypy, and Cog checks passed. The PR is a draft pending the upstream CI matrix.
Codex assisted with the reproduction, patch, and tests.
📚 Documentation preview 📚: https://sqlite-utils--941.org.readthedocs.build/en/941/