Skip to content

Detect JSON input with a UTF-8 BOM #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mint0424 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Detect JSON input with a UTF-8 BOM #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3ea86
Detect JSON input with a UTF-8 BOM (#940)
Mint0424 Nov 13, 2026
eb6127d
Cover UTF-8 BOM input in format detection (#940)
Mint0424 Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sqlite_utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import json
import os
import sys
from codecs import BOM_UTF8
from collections.abc import Callable, Generator, Iterable, Iterator
from typing import (
TYPE_CHECKING,
Expand Down Expand Up @@ -382,7 +383,7 @@ class Format(enum.Enum):
if not first_bytes:
buffered.close()
return (), Format.CSV
if first_bytes.startswith((b"[", b"{")):
if first_bytes.removeprefix(BOM_UTF8).lstrip().startswith((b"[", b"{")):
# JSON is read eagerly, so the detection wrapper can close now,
# including when parsing raises an error.
# TODO: Detect newline-JSON
Expand Down
4 changes: 4 additions & 0 deletions tests/test_rows_from_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import io
import json
from codecs import BOM_UTF8
from io import BytesIO, StringIO

import pytest
Expand All @@ -13,6 +14,9 @@
(b"id,name\n1,Cleo", Format.CSV),
(b"id\tname\n1\tCleo", Format.TSV),
(b'[{"id": "1", "name": "Cleo"}]', Format.JSON),
(BOM_UTF8 + b'[{"id": "1", "name": "Cleo"}]', Format.JSON),
(BOM_UTF8 + b'\n{"id": "1", "name": "Cleo"}', Format.JSON),
(BOM_UTF8 + b"id,name\n1,Cleo", Format.CSV),
),
)
def test_rows_from_file_detect_format(input, expected_format):
Expand Down
Loading