Skip to content

cre-4929: retry limit and auto drop of failing workflows#22853

Merged
mchain0 merged 9 commits into
developfrom
cre-4929
Jul 1, 2026
Merged

cre-4929: retry limit and auto drop of failing workflows#22853
mchain0 merged 9 commits into
developfrom
cre-4929

Conversation

@mchain0

@mchain0 mchain0 commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

limit the number of retries and auto drop the failing workflows

required:

cre-4929

@mchain0 mchain0 requested review from a team as code owners June 16, 2026 12:00
@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
TestIntegration_OCR2_ForwarderFlow The test failed without a specific error message, indicating an unspecified failure during the integration test run. Logs ↗︎
TestShell_CleanupChainTables The test failed because the database server ran out of available connection slots, preventing new connections. Logs ↗︎
Test_AllAtOnceTransmissionSchedule The test failed without a specific error message, but the logs indicate a potential issue with the initialization or configuration of components du... Logs ↗︎
TestIntegration_MercuryV4 The test failed without a specific error message, indicating an unspecified failure during the integration test. Logs ↗︎

... and 29 more

Flaky Test Failure Summary Logs
Test_AllAtOnceZeroDelta_SubmitsDuplicateForwarderTxs The test failed without a specific error message, likely due to an unspecified issue during execution. Logs ↗︎
TestStartHeartbeats/bhs_feeder_startheartbeats_happy_path The test failed without a specific error message, indicating an unspecified failure in the test execution. Logs ↗︎
Test_OneAtATimeTransmissionSchedule The test failed without a specific error message, likely due to an unspecified issue during execution. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

Tofel
Tofel reviewed Jun 16, 2026
View reviewed changes
Comment thread core/services/workflows/syncer/v2/workflow_registry.go
patrickhuie19
patrickhuie19 previously approved these changes Jun 16, 2026
View reviewed changes
@mchain0 mchain0 requested review from Tofel and patrickhuie19 June 16, 2026 14:28
patrickhuie19
patrickhuie19 previously approved these changes Jun 16, 2026
View reviewed changes
Tofel
Tofel previously approved these changes Jun 16, 2026
View reviewed changes
@mchain0 mchain0 dismissed stale reviews from Tofel and patrickhuie19 via 8abe150 June 19, 2026 13:31
@mchain0 mchain0 mentioned this pull request Jun 19, 2026
Merged
@mchain0 mchain0 requested a review from a team as a code owner June 30, 2026 08:43
@mchain0 mchain0 requested a review from Tofel June 30, 2026 08:43
@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@mchain0 mchain0 requested a review from patrickhuie19 June 30, 2026 12:41
cedric-cordenier
cedric-cordenier approved these changes Jun 30, 2026
View reviewed changes

@cedric-cordenier cedric-cordenier left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tofel
Tofel approved these changes Jun 30, 2026
View reviewed changes

@Tofel Tofel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the integration/system-tests related changes

@mchain0 mchain0 enabled auto-merge June 30, 2026 13:55
@mchain0 mchain0 added this pull request to the merge queue Jul 1, 2026
@cl-sonarqube-production

cl-sonarqube-production Bot commented Jul 1, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
4 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 5d2881f Jul 1, 2026
325 of 334 checks passed
@mchain0 mchain0 deleted the cre-4929 branch July 1, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes
@Tofel Tofel Tofel approved these changes
@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez
@kalverra kalverra Awaiting requested review from kalverra
@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mchain0 @patrickhuie19 @cedric-cordenier @Tofel