Skip to content

cre-4929: retry limit and auto drop of failing workflows#22853

Merged
mchain0 merged 9 commits into
developfrom
cre-4929
Jul 1, 2026
Merged

cre-4929: retry limit and auto drop of failing workflows#22853
mchain0 merged 9 commits into
developfrom
cre-4929

cre-4929: minor improvements

dfafc90
Select commit
Loading
Failed to load commit list.
CL-sonarqube-production / SonarQube Code Analysis succeeded Jul 1, 2026 in 1m 16s

Annotations

Check warning on line 378 in core/services/workflows/syncer/v2/handler.go

See this annotation in the file changed.

@cl-sonarqube-production cl-sonarqube-production / SonarQube Code Analysis

Define a constant instead of duplicating this literal "Failed to get organization from linking service" 5 times.

[S1192] String literals should not be duplicated
 See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=22853&issues=512a0145-b83f-4057-b29c-145f1123c10f&open=512a0145-b83f-4057-b29c-145f1123c10f

Check warning on line 786 in core/services/workflows/syncer/v2/workflow_registry.go

See this annotation in the file changed.

@cl-sonarqube-production cl-sonarqube-production / SonarQube Code Analysis

Refactor this method to reduce its Cognitive Complexity from 67 to the 30 allowed.

[S3776] Cognitive Complexity of functions should not be too high
 See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=22853&issues=4e7edb28-0055-4e7a-8ed4-f7ce4a389d0e&open=4e7edb28-0055-4e7a-8ed4-f7ce4a389d0e

Check warning on line 511 in core/services/workflows/events/emit.go

See this annotation in the file changed.

@cl-sonarqube-production cl-sonarqube-production / SonarQube Code Analysis

Define a constant instead of duplicating this literal "workflows.v2." 12 times.

[S1192] String literals should not be duplicated
 See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=22853&issues=068f2908-0ce6-49e5-88ca-62eee0523509&open=068f2908-0ce6-49e5-88ca-62eee0523509

Check warning on line 500 in core/services/workflows/syncer/v2/workflow_registry.go

See this annotation in the file changed.

@cl-sonarqube-production cl-sonarqube-production / SonarQube Code Analysis

Refactor this method to reduce its Cognitive Complexity from 43 to the 30 allowed.

[S3776] Cognitive Complexity of functions should not be too high
 See more on https://sonarqube.main.prod.cldev.sh/project/issues?id=smartcontractkit_chainlink&pullRequest=22853&issues=a4f2480c-aff7-4ec3-a5ac-c36d9098c89d&open=a4f2480c-aff7-4ec3-a5ac-c36d9098c89d